feat(screenshot): Loosen restrictions on Screenshot widget #93024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he attachments This expands the criteria to show the Screenshots component when at least one attachment ends with `screenshot.png` or `screenshot.jpg`.
github-actions
bot
added
the
Scope: Frontend
roggenkemper
reviewed
Jun 6, 2025
| const screenshots = | ||
| attachments?.filter(({name}) => SCREENSHOT_NAMES.includes(name)) ?? []; | ||
| attachments?.filter( | ||
| ({name}) => name.endsWith('screenshot.jpg') || name.endsWith('screenshot.png') |
Member
There was a problem hiding this comment.
do we know if "screenshot-1" is still a case we want to cover?
Member
Author
There was a problem hiding this comment.
I will expand the test case on Monday. There's no one with certainty as to what they want.
yuvmen
reviewed
Jun 6, 2025
| const screenshots = | ||
| attachments?.filter(({name}) => SCREENSHOT_NAMES.includes(name)) ?? []; | ||
| attachments?.filter( | ||
| ({name}) => name.endsWith('screenshot.jpg') || name.endsWith('screenshot.png') |
Member
There was a problem hiding this comment.
wont this possibly cause a regression? SCREENSHOT NAMES also includes:
'screenshot-1.jpg',
'screenshot-1.png',
'screenshot-2.jpg',
'screenshot-2.png',
which this wont pick up now right?
Member
There was a problem hiding this comment.
hmm oops, yea same as what Richard said
yuvmen
approved these changes
Jun 6, 2025
armenzg
force-pushed
the
feat/show_screenshot/armenzg
branch
from
a870ad4 to
6be73a6
Compare
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
This expands the criteria to show the Screenshots component when at least one attachment ends with `screenshot.png` or `screenshot.jpg`. This is a follow-up to #91602. This widget: <img width="164" alt="image" src="https://github.com/user-attachments/assets/37bafd95-0464-4604-b0f8-46e6479ce29a" />
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the criteria to show the Screenshots component when at least one attachment ends with
screenshot.pngorscreenshot.jpg.This is a follow-up to #91602.
This widget:
