Fix invalid URL in admin/projects/list.html. #950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the project_list contains a project that is not associated with a team (such as "Sentry (Internal)"), then URL generation for the sentry-stream and sentry-manage-project URLs breaks. The "fix" is to not emit the URLs that we cannot possibly generate without a team slug.
|
Coverage remained the same when pulling 6393ede on dave-shawley:fix-admin-template-internal-team into 3b7bd8a on getsentry:master. |
dcramer
added a commit
that referenced
this pull request
Jul 26, 2013
…-team Fix invalid URL in admin/projects/list.html.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
project_listcontains a project that is not associated with a team (such as "Sentry (Internal)"), then URL generation for the sentry-stream and sentry-manage-project URLs breaks. The "fix" is to not emit the URLs that we cannot possibly generate without a team slug.