ref(insights): Improve TimeSeriesWidgetVisualization series name rendering#95078
Merged
Conversation
Use the specific function they actually need, rather than the whole series formatter, so I can change the function freely.
This way we can use all information about the `TimeSeries`, like its `groupBy`
github-actions
Bot
added
the
Scope: Frontend
michellewzhang
approved these changes
Jul 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95078 +/- ##
==========================================
- Coverage 84.61% 83.40% -1.21%
==========================================
Files 10448 10448
Lines 604624 604621 -3
Branches 23607 23604 -3
==========================================
- Hits 511613 504303 -7310
- Misses 92522 99829 +7307
Partials 489 489 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 14, 2025
…ndering (#95078) Preparation for an incoming refactor. 1. `formatSeriesName` is now called `formatTimeSeriesName`, because it accepts a `TimeSeries`! This is an important change because soon I will take `TimeSeries.groupBy` into account when formatting the names 2. Remove direct usage for `formatSeriesName` from Release Health charts. That's a very specific usage, it's _only_ doing version formatting, so it should use the underlying helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for an incoming refactor.
formatSeriesNameis now calledformatTimeSeriesName, because it accepts aTimeSeries! This is an important change because soon I will takeTimeSeries.groupByinto account when formatting the namesformatSeriesNamefrom Release Health charts. That's a very specific usage, it's only doing version formatting, so it should use the underlying helper