chore(dynamic-sampling): remove unused function get_rule_type#95108
Merged
shellmayr merged 1 commit intoJul 9, 2025
Conversation
shellmayr
commented
Jul 9, 2025
Member
- Was used only in a logging script that was deleted in #70718 (files)
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95108 +/- ##
=======================================
Coverage 87.87% 87.87%
=======================================
Files 10454 10454
Lines 604696 604690 -6
Branches 23617 23617
=======================================
- Hits 531351 531346 -5
+ Misses 72987 72986 -1
Partials 358 358 |
obostjancic
approved these changes
Jul 9, 2025
d52a773 to
ebbc116
Compare
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.