fix(replay): Adjust sizing/padding of replay tabs#95146
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
billyvg
approved these changes
Jul 9, 2025
michellewzhang
approved these changes
Jul 9, 2025
ryan953
added a commit
that referenced
this pull request
Jul 9, 2025
I chose the `xs + summary + no-border` version but added images for a few other variants to see what they look like too. In UI1 everything looks fine, in all these variants. So I only took UI2 screenshots, and tweaked that. More notes below.... | | XS | SM | | --- | --- | --- | | "AI" | <img width="1355" alt="xs - ai" src="https://github.com/user-attachments/assets/dfc76f5d-15ab-41dd-90a7-580de27142bd" /> | <img width="1355" alt="sm - ai" src="https://github.com/user-attachments/assets/be0ab4d2-1634-45fc-83bf-65a23ae639fd" /> | "Summary" | <img width="1355" alt="xs - summary" src="https://github.com/user-attachments/assets/bdfd0a1d-29a8-463d-9143-7291a3d8ab38" /> | <img width="1355" alt="sm - summary" src="https://github.com/user-attachments/assets/1ce991e0-0b08-47b8-9c03-4ed7036bea66" /> | "Chapters" | <img width="1355" alt="xs - chapters" src="https://github.com/user-attachments/assets/de3eedc5-79a9-4d2d-95ca-6fe3eb4dafe4" /> | <img width="1355" alt="sm - chapters" src="https://github.com/user-attachments/assets/6121e9d8-4ac4-4510-805c-50fe860787b6" /> | "Chapters" (no border) | <img width="1355" alt="xs - chapters - noline" src="https://github.com/user-attachments/assets/62f24c83-9294-4860-8065-78f276c73a22" /> | <img width="1355" alt="sm - chapters - noline" src="https://github.com/user-attachments/assets/c7d0b3f4-99cf-4e5f-ad11-676683e8235f" /> **Sizes** With `xs` text is a smaller than before, which is weird to look at, but i like how it lets the left & right sides of the page line up. <img width="249" alt="SCR-20250709-jzev" src="https://github.com/user-attachments/assets/0af6da97-da9f-4f4f-a72a-d75a433a0e5a" /> **Label** The label 'chapters' is already visible when one of these expando's is opened, but nothing is inside it. However 'replay summary' is used as the title inside the tab, so naming the tab 'summary' aligns with that So it could go either way. <img width="608" alt="sm - chapters -item open" src="https://github.com/user-attachments/assets/78cbe3ba-f487-47db-96da-5d7a0e1b9181" /> **Border** The border question looks a bit different on the other tabs, where there's a filter+search box instead of the Panel <img width="636" alt="SCR-20250709-jyxd" src="https://github.com/user-attachments/assets/1f51c2f8-540a-448c-a983-961b8407ce2e" /> Fixes REPLAY-476
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 14, 2025
I chose the `xs + summary + no-border` version but added images for a few other variants to see what they look like too. In UI1 everything looks fine, in all these variants. So I only took UI2 screenshots, and tweaked that. More notes below.... | | XS | SM | | --- | --- | --- | | "AI" | <img width="1355" alt="xs - ai" src="https://github.com/user-attachments/assets/dfc76f5d-15ab-41dd-90a7-580de27142bd" /> | <img width="1355" alt="sm - ai" src="https://github.com/user-attachments/assets/be0ab4d2-1634-45fc-83bf-65a23ae639fd" /> | "Summary" | <img width="1355" alt="xs - summary" src="https://github.com/user-attachments/assets/bdfd0a1d-29a8-463d-9143-7291a3d8ab38" /> | <img width="1355" alt="sm - summary" src="https://github.com/user-attachments/assets/1ce991e0-0b08-47b8-9c03-4ed7036bea66" /> | "Chapters" | <img width="1355" alt="xs - chapters" src="https://github.com/user-attachments/assets/de3eedc5-79a9-4d2d-95ca-6fe3eb4dafe4" /> | <img width="1355" alt="sm - chapters" src="https://github.com/user-attachments/assets/6121e9d8-4ac4-4510-805c-50fe860787b6" /> | "Chapters" (no border) | <img width="1355" alt="xs - chapters - noline" src="https://github.com/user-attachments/assets/62f24c83-9294-4860-8065-78f276c73a22" /> | <img width="1355" alt="sm - chapters - noline" src="https://github.com/user-attachments/assets/c7d0b3f4-99cf-4e5f-ad11-676683e8235f" /> **Sizes** With `xs` text is a smaller than before, which is weird to look at, but i like how it lets the left & right sides of the page line up. <img width="249" alt="SCR-20250709-jzev" src="https://github.com/user-attachments/assets/0af6da97-da9f-4f4f-a72a-d75a433a0e5a" /> **Label** The label 'chapters' is already visible when one of these expando's is opened, but nothing is inside it. However 'replay summary' is used as the title inside the tab, so naming the tab 'summary' aligns with that So it could go either way. <img width="608" alt="sm - chapters -item open" src="https://github.com/user-attachments/assets/78cbe3ba-f487-47db-96da-5d7a0e1b9181" /> **Border** The border question looks a bit different on the other tabs, where there's a filter+search box instead of the Panel <img width="636" alt="SCR-20250709-jyxd" src="https://github.com/user-attachments/assets/1f51c2f8-540a-448c-a983-961b8407ce2e" /> Fixes REPLAY-476
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I chose the
xs + summary + no-borderversion but added images for a few other variants to see what they look like too.In UI1 everything looks fine, in all these variants. So I only took UI2 screenshots, and tweaked that.
More notes below....
Sizes
With
xstext is a smaller than before, which is weird to look at, but i like how it lets the left & right sides of the page line up.Label
The label 'chapters' is already visible when one of these expando's is opened, but nothing is inside it.
However 'replay summary' is used as the title inside the tab, so naming the tab 'summary' aligns with that
So it could go either way.
Border
The border question looks a bit different on the other tabs, where there's a filter+search box instead of the Panel
Fixes REPLAY-476