Reinstate count from emails.#957
Closed
rogerhu wants to merge 1 commit into
Closed
Conversation
Member
|
The main reason we removed this is because it's quite useless in first-seen emails (its always 1) and it doesnt update dynamically (e.g. something like an image) for regression emails. i.e. the email is sent now, you view it tomorrow, and its had 100000000 more errors since then, so the count is super inaccurate |
Member
|
Closing this out for reasons stated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any reason it was removed? We found it incredibly useful.