Skip to content

Reinstate count from emails.#957

Closed
rogerhu wants to merge 1 commit into
getsentry:masterfrom
rogerhu:reinstate_count
Closed

Reinstate count from emails.#957
rogerhu wants to merge 1 commit into
getsentry:masterfrom
rogerhu:reinstate_count

Conversation

@rogerhu
Copy link
Copy Markdown
Contributor

@rogerhu rogerhu commented Aug 3, 2013

Any reason it was removed? We found it incredibly useful.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 287df42 on rogerhu:reinstate_count into 646adc4 on getsentry:master.

@dcramer
Copy link
Copy Markdown
Member

dcramer commented Aug 3, 2013

The main reason we removed this is because it's quite useless in first-seen emails (its always 1) and it doesnt update dynamically (e.g. something like an image) for regression emails.

i.e. the email is sent now, you view it tomorrow, and its had 100000000 more errors since then, so the count is super inaccurate

@dcramer
Copy link
Copy Markdown
Member

dcramer commented Aug 20, 2013

Closing this out for reasons stated

@dcramer dcramer closed this Aug 20, 2013
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants