fix(spans-migration): Round off percentiles instead of dropping the field#95714
Merged
nikkikapadia merged 2 commits intoJul 18, 2025
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #95714 +/- ##
==========================================
+ Coverage 82.56% 83.93% +1.37%
==========================================
Files 10563 10572 +9
Lines 608794 610197 +1403
Branches 23913 23913
==========================================
+ Hits 502623 512199 +9576
+ Misses 105784 97611 -8173
Partials 387 387 |
shruthilayaj
approved these changes
Jul 18, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 21, 2025
…ield (#95714) Instead of dropping all percentile fields that don't align with supported fields, I'm rounding them off to the closest supported field. For example, `percentile(transaction.duration,0.94)` would map to `p95(span.duration)`. intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of dropping all percentile fields that don't align with supported fields, I'm rounding them off to the closest supported field. For example,
percentile(transaction.duration,0.94)would map top95(span.duration).intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.