Skip to content

Conversation

@ameliahsu
Copy link
Member

@ameliahsu ameliahsu commented Aug 11, 2025

  • automation list view -> rule list view
  • automation create (new) view -> rule create (new) view
  • automation detail view -> rule list view (because with de-duplication of automations, automations will not always map 1:1 with a single alert rule/rule)

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 11, 2025
!user.isStaff && !organization.features.includes('workflow-engine-ui');

if (shouldRedirect) {
navigate(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React doesn't like side-effects being called by the render function. Usually we'd put this in a useEffect, but we have a Redirect component that you can return here instead that would be best

@malwilley
Copy link
Member

Should we remove the useWorkflowEngineFeatureGate() calls as part of this?

@getsantry
Copy link
Contributor

getsantry bot commented Sep 18, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Sep 18, 2025
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
..._engine/endpoints/validators/alertrule_workflow.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           mia/aci/get-alertrule-workflow   #97583      +/-   ##
==================================================================
+ Coverage                           80.66%   80.68%   +0.01%     
==================================================================
  Files                                8547     8550       +3     
  Lines                              376144   376253     +109     
  Branches                            24443    24443              
==================================================================
+ Hits                               303422   303567     +145     
+ Misses                              72350    72314      -36     
  Partials                              372      372              

@getsantry getsantry bot removed the Stale label Sep 19, 2025
@getsantry getsantry bot added the Stale label Nov 5, 2025
@ameliahsu ameliahsu force-pushed the mia/aci/get-alertrule-workflow branch from e5d511c to 933da60 Compare November 10, 2025 22:58
Base automatically changed from mia/aci/get-alertrule-workflow to master November 10, 2025 23:28
@getsantry getsantry bot removed the Stale label Nov 11, 2025
@ameliahsu ameliahsu marked this pull request as ready for review November 12, 2025 17:42
@ameliahsu ameliahsu requested a review from a team as a code owner November 12, 2025 17:42
@ameliahsu ameliahsu requested a review from malwilley November 12, 2025 17:42
@ameliahsu ameliahsu marked this pull request as draft November 12, 2025 18:12
export default function AutomationEdit() {
const params = useParams<{automationId: string}>();

useWorkflowEngineFeatureGate({redirect: true});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also call this on DetectorViewContainer which is the top level component for automations and detectors, so I think we need to remove it on that file as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the callout, I'll wait until I have all of the detector redirects set up to safely remove it on the DetectorViewContainer

@ameliahsu ameliahsu merged commit 7222cf4 into master Nov 13, 2025
49 checks passed
@ameliahsu ameliahsu deleted the mia/aci/automations-redirect branch November 13, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants