feat(preprod): Remove enum on vcs provider field#97598
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #97598 +/- ##
========================================
Coverage 80.62% 80.63%
========================================
Files 8560 8562 +2
Lines 376889 377194 +305
Branches 24538 24538
========================================
+ Hits 303867 304138 +271
- Misses 72652 72686 +34
Partials 370 370 |
NicoHinderling
approved these changes
Aug 11, 2025
Contributor
There was a problem hiding this comment.
Bug: Missing Test for Long Repository Names
The test_head_repo_name_too_long test was incorrectly removed. The head_repo_name field retains its maxLength: 255 schema validation, making this test, which verifies rejection of strings longer than 255 characters, still relevant and necessary for coverage.
tests/sentry/preprod/api/endpoints/test_organization_preprod_artifact_assemble.py#L157-L172
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 12, 2025
Noticed the CLI already has some parsing mechanisms for the VCS provider. These pull out the base URL from a given VCS url, so we should leverage this. In the future we can add logic to the backend to determine the "simple provider" from these URLs. Sentry-cli parsing: <img width="576" height="855" alt="Screenshot 2025-08-11 at 11 22 19 AM" src="https://github.com/user-attachments/assets/f0bccb0a-c575-4005-b807-7859dee66de3" />
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
Noticed the CLI already has some parsing mechanisms for the VCS provider. These pull out the base URL from a given VCS url, so we should leverage this. In the future we can add logic to the backend to determine the "simple provider" from these URLs. Sentry-cli parsing: <img width="576" height="855" alt="Screenshot 2025-08-11 at 11 22 19 AM" src="https://github.com/user-attachments/assets/f0bccb0a-c575-4005-b807-7859dee66de3" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Noticed the CLI already has some parsing mechanisms for the VCS provider. These pull out the base URL from a given VCS url, so we should leverage this. In the future we can add logic to the backend to determine the "simple provider" from these URLs.
Sentry-cli parsing:
