fix(issues): Add typing to around event_frames #97898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
yuvmen
approved these changes
Aug 14, 2025
cvxluo
approved these changes
Aug 14, 2025
Contributor
cvxluo
left a comment
cvxluo
left a comment
There was a problem hiding this comment.
nice fix, may want an experienced python typer to look
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
# Summary I picked up [SENTRY-45X5](https://sentry.sentry.io/issues/6731943173/) on a lark. It seems like we're somehow getting `event_frames` full of `None` returns. While trying to figure that out, I jumped around and typed every instance of `event_frames`. Figured it'd be better to put it up as a PR than not. # Test Plan Only changes are typing changes; `mypy` no errors.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 26, 2025
# Summary I picked up [SENTRY-45X5](https://sentry.sentry.io/issues/6731943173/) on a lark. It seems like we're somehow getting `event_frames` full of `None` returns. While trying to figure that out, I jumped around and typed every instance of `event_frames`. Figured it'd be better to put it up as a PR than not. # Test Plan Only changes are typing changes; `mypy` no errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I picked up SENTRY-45X5 on a lark. It seems like we're somehow getting
event_framesfull ofNonereturns. While trying to figure that out, I jumped around and typed every instance ofevent_frames. Figured it'd be better to put it up as a PR than not.Test Plan
Only changes are typing changes;
mypyno errors.