Load view hierarchies only once during processing #98512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves view hierarchy handling into its own file, and changes the java language processor in such a way that it only loads the view hierarchy once. Previously, it would load them twice, once to collect all the window class names, and then a second time to actually deobfuscate it.
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #98512 +/- ##
==========================================
- Coverage 81.18% 81.16% -0.02%
==========================================
Files 8546 8547 +1
Lines 376600 376806 +206
Branches 23961 23961
==========================================
+ Hits 305738 305851 +113
- Misses 70496 70589 +93
Partials 366 366 |
buenaflor
reviewed
Aug 29, 2025
Contributor
buenaflor
left a comment
buenaflor
left a comment
There was a problem hiding this comment.
I'm not too familiar with the view hierarchy symbolication for Java so I don't think I can comment too much on this PR
jan-auer
approved these changes
Aug 29, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Sep 9, 2025
This moves view hierarchy handling into its own file, and changes the java language processor in such a way that it only loads the view hierarchy once. Previously, it would load them twice, once to collect all the window class names, and then a second time to actually deobfuscate it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves view hierarchy handling into its own file, and changes the java language processor in such a way that it only loads the view hierarchy once.
Previously, it would load them twice, once to collect all the window class names, and then a second time to actually deobfuscate it.