Skip to content

Conversation

@lzhao-sentry
Copy link
Contributor

@lzhao-sentry lzhao-sentry commented Aug 29, 2025

Changes

Added strategy fixed to prevent dropdown cutting out when few dashboards exist

Also disabled overflow prevention because I think the library used for the dropdown has a bug with placing the dropdown. Not ideal, but the user would have to go out of their way to shrink the tab really small to notice this.

Before

Screenshot 2025-08-29 at 10 10 34 AM

After

Screenshot 2025-08-29 at 10 08 25 AM

@lzhao-sentry lzhao-sentry requested a review from a team August 29, 2025 14:14
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 29, 2025
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🙏 🙏 🙏

@lzhao-sentry lzhao-sentry enabled auto-merge (squash) August 29, 2025 14:24
@lzhao-sentry lzhao-sentry merged commit 2859d59 into master Aug 29, 2025
48 checks passed
@lzhao-sentry lzhao-sentry deleted the lzhao/fix/dashboards-access-dropdown-overflow branch August 29, 2025 14:26
constantinius pushed a commit that referenced this pull request Sep 1, 2025
…hboards exist (#98519)

### Changes

Added strategy fixed to prevent dropdown cutting out when few dashboards
exist

Also disabled overflow prevention because I think the library used for
the dropdown has a bug with placing the dropdown. Not ideal, but the
user would have to go out of their way to shrink the tab really small to
notice this.

### Before
<img width="1492" height="196" alt="Screenshot 2025-08-29 at 10 10
34 AM"
src="https://github.com/user-attachments/assets/95af02f1-ac11-48ce-8942-096d99a6d626"
/>

### After

<img width="1494" height="623" alt="Screenshot 2025-08-29 at 10 08
25 AM"
src="https://github.com/user-attachments/assets/61ec7eb2-b094-415a-b394-b19fd7fb59bd"
/>
andrewshie-sentry pushed a commit that referenced this pull request Sep 9, 2025
…hboards exist (#98519)

### Changes

Added strategy fixed to prevent dropdown cutting out when few dashboards
exist

Also disabled overflow prevention because I think the library used for
the dropdown has a bug with placing the dropdown. Not ideal, but the
user would have to go out of their way to shrink the tab really small to
notice this.

### Before
<img width="1492" height="196" alt="Screenshot 2025-08-29 at 10 10
34 AM"
src="https://github.com/user-attachments/assets/95af02f1-ac11-48ce-8942-096d99a6d626"
/>

### After

<img width="1494" height="623" alt="Screenshot 2025-08-29 at 10 08
25 AM"
src="https://github.com/user-attachments/assets/61ec7eb2-b094-415a-b394-b19fd7fb59bd"
/>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants