ref: unify icon exports #98563
Merged
ref: unify icon exports #98563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
# Conflicts: # static/app/icons/iconBuilding.tsx # static/app/icons/iconCompass.tsx # static/app/icons/iconPrevent.tsx
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
JonasBa
reviewed
Sep 12, 2025
| function IconCodecov(props: SVGIconProps) { | ||
| export function IconCodecov(props: SVGIconProps) { | ||
| return ( | ||
| <SvgIcon {...props} viewBox="0 0 24 24" kind="path"> |
There was a problem hiding this comment.
Looks like we need to run some of these through svgo, the precision on these seems excessive - we rarely need more than 2 decimal precision
JonasBa
approved these changes
Sep 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
displayNamesetting. This was a left-over from when we hadforwardRef. Now, Icons are just regular named functions, so they will have a correctdisplayNameset automatically.export { Icon... }withexport function Icon..., as this is what we do everywhere else too.