Skip to content

Conversation

@JshWright
Copy link
Contributor

We make heavy use of IPv6, and would like to make use of the UDP transport.

This patch does the right thing in most cases. If you give it numeric address, it will certainly do what's expected. If you give it a hostname (and that hostname has both v4 and v6 addresses), then what happens is up to the order in which the resolver returns the addresses.

This is consistent with relevant Python socket library documentation:

If you use a hostname in the host portion of IPv4/v6 socket address, the program may show a nondeterministic behavior, as Python uses the first address returned from the DNS resolution. The socket address will be resolved differently into an actual IPv4/v6 address, depending on the results from DNS resolution and/or the host configuration. For deterministic behavior use a numeric address in host portion.

@dcramer
Copy link
Member

dcramer commented Sep 4, 2013

Seems sane, but you should note that we've more or less considered UDP a failure in Sentry as message sizes are too large

dcramer added a commit that referenced this pull request Sep 4, 2013
Enable IPv6 support for the UDP server
@dcramer dcramer merged commit 82ebbd8 into getsentry:master Sep 4, 2013
@JshWright
Copy link
Contributor Author

In that case, doesn't IPv6 (specifically RFC 2675) make the message size less of a concern?

@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants