fix(preprod): Enable downloads for uploaded APK artifacts#98812
Merged
runningcode merged 1 commit intomasterfrom Sep 4, 2025
Merged
fix(preprod): Enable downloads for uploaded APK artifacts#98812runningcode merged 1 commit intomasterfrom
runningcode merged 1 commit intomasterfrom
Conversation
APK files that were uploaded as build artifacts couldn't be downloaded because their installable_app_file_id field remained null. Unlike AAB files which get converted to APK format during processing, APK files are already installable and don't need conversion. When APK artifacts transition to PROCESSED state, automatically set installable_app_file_id to match file_id since APK files are already in installable format. This enables downloads using the same mechanism as converted AAB→APK files.
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #98812 +/- ##
==========================================
- Coverage 81.20% 81.20% -0.01%
==========================================
Files 8531 8531
Lines 376737 376715 -22
Branches 23892 23892
==========================================
- Hits 305931 305911 -20
+ Misses 70439 70437 -2
Partials 367 367 |
noahsmartin
approved these changes
Sep 4, 2025
armenzg
pushed a commit
that referenced
this pull request
Sep 5, 2025
## Summary - Fix APK artifact downloads that were previously blocked due to missing `installable_app_file_id` ## Changes Previously, uploaded APK files couldn't be downloaded because: - AAB files get converted to APK format during processing and populate `installable_app_file_id` - APK files are uploaded directly but `installable_app_file_id` remained null - Download logic requires non-null `installable_app_file_id` This change automatically sets `installable_app_file_id = file_id` for APK artifacts when they transition to PROCESSED state, since APK files are already in installable format and don't need conversion like AAB files.
runningcode
added a commit
that referenced
this pull request
Sep 5, 2025
…8812)" (#98887) This would short-circuit the logic in launchpad which is not what we want if we want to resign the APK. This reverts commit 376ac6b. <!-- Describe your PR here. --> <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Sep 9, 2025
## Summary - Fix APK artifact downloads that were previously blocked due to missing `installable_app_file_id` ## Changes Previously, uploaded APK files couldn't be downloaded because: - AAB files get converted to APK format during processing and populate `installable_app_file_id` - APK files are uploaded directly but `installable_app_file_id` remained null - Download logic requires non-null `installable_app_file_id` This change automatically sets `installable_app_file_id = file_id` for APK artifacts when they transition to PROCESSED state, since APK files are already in installable format and don't need conversion like AAB files.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Sep 9, 2025
…8812)" (#98887) This would short-circuit the logic in launchpad which is not what we want if we want to resign the APK. This reverts commit 376ac6b. <!-- Describe your PR here. --> <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
installable_app_file_idChanges
Previously, uploaded APK files couldn't be downloaded because:
installable_app_file_idinstallable_app_file_idremained nullinstallable_app_file_idThis change automatically sets
installable_app_file_id = file_idfor APK artifacts when they transition to PROCESSED state, since APK files are already in installable format and don't need conversion like AAB files.