Skip to content

chore(aci milestone 3): disable manual priority setting for metric issues#99078

Merged
mifu67 merged 3 commits into
masterfrom
mifu67/aci/disable-manual-priority-updates-be
Sep 9, 2025
Merged

chore(aci milestone 3): disable manual priority setting for metric issues#99078
mifu67 merged 3 commits into
masterfrom
mifu67/aci/disable-manual-priority-updates-be

Conversation

@mifu67

@mifu67 mifu67 commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Requires #99082

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 8, 2025
@mifu67 mifu67 requested a review from a team September 8, 2025 23:03
@mifu67 mifu67 marked this pull request as ready for review September 8, 2025 23:03
@mifu67 mifu67 requested a review from a team as a code owner September 8, 2025 23:03

@saponifi3d saponifi3d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 thanks for making this a grouptype setting too.

@codecov

codecov Bot commented Sep 9, 2025

Copy link
Copy Markdown

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
27671 5 27666 598
View the top 3 failed test(s) by shortest run time
tests.snuba.api.endpoints.test_organization_events_stats_mep.OrganizationEventsStatsMetricsEnhancedPerformanceEndpointTest::test_metrics_enhanced_with_has_filter_falls_back_to_indexed_data
Stack Traces | 6.03s run time
#x1B[1m#x1B[.../api/endpoints/test_organization_events_stats_mep.py#x1B[0m:1075: in test_metrics_enhanced_with_has_filter_falls_back_to_indexed_data
    assert response.data["data"][0][1][0]["count"] == 222
#x1B[1m#x1B[31mE   assert 0 == 222#x1B[0m
tests.snuba.tagstore.test_tagstore_backend.TagStorageTest::test_get_top_group_tag_values_generic
Stack Traces | 8.69s run time
#x1B[1m#x1B[.../snuba/tagstore/test_tagstore_backend.py#x1B[0m:367: in test_get_top_group_tag_values_generic
    resp = self.ts.get_top_group_tag_values(
#x1B[1m#x1B[.../tagstore/snuba/backend.py#x1B[0m:675: in get_top_group_tag_values
    tag = self.__get_tag_key_and_top_values(
#x1B[1m#x1B[.../tagstore/snuba/backend.py#x1B[0m:207: in __get_tag_key_and_top_values
    raise TagKeyNotFound if group is None else GroupTagKeyNotFound
#x1B[1m#x1B[31mE   sentry.tagstore.exceptions.GroupTagKeyNotFound#x1B[0m
tests.snuba.tagstore.test_tagstore_backend.TagStorageTest::test_get_group_tag_value_count_generic
Stack Traces | 8.75s run time
#x1B[1m#x1B[.../snuba/tagstore/test_tagstore_backend.py#x1B[0m:400: in test_get_group_tag_value_count_generic
    assert (
#x1B[1m#x1B[31mE   AssertionError: assert 0 == 1#x1B[0m
#x1B[1m#x1B[31mE    +  where 0 = <bound method SnubaTagStorage.get_group_tag_value_count of <sentry.tagstore.snuba.backend.SnubaTagStorage object at 0x7f41a41c0be0>>(<Group at 0x7f41cc9e6990: id=424, project_id=4556734751047680>, 314, 'foo', {'organization_id': 1234, 'referrer': 'tagstore.get_group_tag_value_count'})#x1B[0m
#x1B[1m#x1B[31mE    +    where <bound method SnubaTagStorage.get_group_tag_value_count of <sentry.tagstore.snuba.backend.SnubaTagStorage object at 0x7f41a41c0be0>> = <sentry.tagstore.snuba.backend.SnubaTagStorage object at 0x7f41a41c0be0>.get_group_tag_value_count#x1B[0m
#x1B[1m#x1B[31mE    +      where <sentry.tagstore.snuba.backend.SnubaTagStorage object at 0x7f41a41c0be0> = <tests.snuba.tagstore.test_tagstore_backend.TagStorageTest testMethod=test_get_group_tag_value_count_generic>.ts#x1B[0m
#x1B[1m#x1B[31mE    +    and   314 = <Environment at 0x7f41c79313d0: id=314, organization_id=4556734750982144, name='test'>.id#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@mifu67 mifu67 merged commit 12f09f7 into master Sep 9, 2025
64 checks passed
@mifu67 mifu67 deleted the mifu67/aci/disable-manual-priority-updates-be branch September 9, 2025 20:49
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants