feat(insights): Adds web vitals seer suggestion issues to web vital meters#99483
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #99483 +/- ##
==========================================
- Coverage 81.21% 81.21% -0.01%
==========================================
Files 8585 8585
Lines 380186 380177 -9
Branches 24106 24103 -3
==========================================
- Hits 308771 308763 -8
+ Misses 71069 71068 -1
Partials 346 346 |
Comment on lines
+34
to
+42
| // For issue.type:web_vitals, we also want to filter for a specific web_vital tag. | ||
| // However, the issues api doesn't support OR conditions, so we can't apply a filter to the web_vital tag without it affecting all other filter conditions. | ||
| // To get around this, we instead filter out all other web_vital tags except the one we want to filter for. | ||
| if (webVital) { | ||
| mutableSearch.addFilterValue( | ||
| '!web_vital', | ||
| `[${ORDER.filter(v => v !== webVital).join(',')}]` | ||
| ); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This might be a little confusing. Here's an example. We want to do:
(issue.type:[performance_render_blocking_asset_span,...] ) OR (issue.type:web_vitals web_vital:lcp)
The issue api doesn't support OR syntax though. So an equivalent hack without using OR would be:
issue.type:[web_vitals, performance_render_blocking_asset_span,...] !web_vital:[fcp,inp,cls,ttfb])
This works because no other issue type uses the web_vital tag
narsaynorath
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Web Vital meters to also query and link to Seer/Autofix Suggestion issues:
