chore: Update datetime method to clean up noisy log #99542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
NicoHinderling
force-pushed
the
update-datetime-get-rid-of-noisy-log
branch
from
ee2e096 to
051c182
Compare
|
✅ All tests passed |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
NicoHinderling
force-pushed
the
update-datetime-get-rid-of-noisy-log
branch
from
051c182 to
f5fa84d
Compare
NicoHinderling
force-pushed
the
update-datetime-get-rid-of-noisy-log
branch
from
f5fa84d to
7216c73
Compare
NicoHinderling
force-pushed
the
update-datetime-get-rid-of-noisy-log
branch
from
7216c73 to
6004b97
Compare
NicoHinderling
changed the title
markstory
approved these changes
Oct 27, 2025
thetruecpaul
approved these changes
Oct 27, 2025
| # Need to support timezone-aware and naive datetimes since | ||
| # Snuba API only deals in naive UTC | ||
| now = datetime.now(UTC) if start.tzinfo else datetime.utcnow() | ||
| now = datetime.now(UTC) if start.tzinfo else datetime.now(UTC).replace(tzinfo=None) |
Contributor
There was a problem hiding this comment.
Wait, wouldn't replacing the tzinfo with None remove the UTC?
In other words: in the existing definition:
datetime.now(UTC) if start.tzinfo else datetime.utcnow()
How are datetime.now(UTC) and datetime.utcnow() different?
Contributor
There was a problem hiding this comment.
Hm, digging in I see that replace does leave the time alone, so this shouldn't be a problem. LGTM.
Contributor
Author
There was a problem hiding this comment.
hehe yeah I was confused by this too
shashjar
approved these changes
Oct 27, 2025
priscilawebdev
pushed a commit
that referenced
this pull request
Oct 28, 2025
While looking through GCP logs, I see this noisy log showing up a ton: ``` /usr/src/sentry/src/sentry/utils/dates.py:193: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC). ``` lets address it
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
While looking through GCP logs, I see this noisy log showing up a ton: ``` /usr/src/sentry/src/sentry/utils/dates.py:193: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC). ``` lets address it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking through GCP logs, I see this noisy log showing up a ton:
lets address it