fix: to check all items in an envelope for errors #880

Shubhdeep12 · 2025-08-06T18:11:47Z

Before opening this PR:

I added a Changeset Entry with pnpm changeset:add
I referenced issues that this PR addresses

codecov · 2025-08-06T18:13:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.31%. Comparing base (7640f9f) to head (aa615e8).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #880   +/-   ##
=======================================
  Coverage   31.31%   31.31%           
=======================================
  Files         127      127           
  Lines        9562     9562           
  Branches      133      133           
=======================================
  Hits         2994     2994           
  Misses       6568     6568

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vercel · 2025-08-06T18:14:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
spotlightjs	⬜️ Skipped (Inspect)			Aug 8, 2025 5:09am

seer-by-sentry · 2025-08-06T18:16:08Z

packages/sidecar/src/mcp/index.ts

+              const [{ type }, payload] = item;
+              if (type === "event" && isErrorEvent(payload)) {


Potential bug: The code destructures `type` from an envelope item header. This will crash if the `type` field is missing, a case handled defensively elsewhere in the codebase.

Description: The code at packages/sidecar/src/mcp/index.ts uses destructuring const [{ type }, payload] = item; to extract the type from an envelope item's header. However, other parts of the codebase use defensive patterns like optional chaining (item?.[0].type) and explicit checks (if (itemHeader.type)), indicating that the type field can be missing in practice. This new, non-defensive approach will throw a TypeError if it processes an envelope item header that lacks a type property, causing the get_errors tool to crash.

Suggested fix: Instead of direct destructuring, access the type property safely. Check for the existence of the header and the type property before using it. For example: const type = item?.[0]?.type; if (type) { /* ... */ }.
_{severity: 0.6, confidence: 0.9}

_{Did we get this right? 👍 / 👎 to inform future reviews.}

BYK

cc @MathurAditya724

BYK · 2025-08-07T13:43:14Z

packages/sidecar/src/mcp/index.ts

          if (a_sent_at > b_sent_at) return -1;
          return 0;
+        })
+        .flatMap(processed => {


Let's move .flatMap() before sort so we don't spend time sorting filtered items? :)

Actually, moving this later makes sorting proper so it should be part of the patch.

looks like code was updated after this patch. fixed it again.
you can review now
thanks

MathurAditya724

Thanks for the PR! 😄

Just left some small changes/preferences

MathurAditya724 · 2025-08-07T16:20:29Z

packages/sidecar/src/mcp/index.ts

-    return formatEventOutput(processErrorEvent(payload));
-  }
+  const formattedErrors = items
+    .map(item => {


Can we just use a for loop, which pushes to an array only when we have the data. Just to remove these 2 loops

yes we can do that.
thanks

MathurAditya724 · 2025-08-07T16:25:36Z

packages/sidecar/src/mcp/index.ts

+
+          if (formattedErrors?.length) {
+            for (const formattedError of formattedErrors) {
+              if (formattedError) {


Why do we need the if check again over here? We already have removed the undefined values in the formatErrorEnvelope function.

You can make this a one liner add all the data using push in the content array and formatting then with map

thanks, fixed it

MathurAditya724

LGTM! 🚀

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/overlay@4.0.0 ### Major Changes - Remove integrations architecture in favour of fixed telemetry features and remove the ability to use the package as an overlay on top of apps. ([#917](#917)) - Remove all vite-plugins as they are deprecated ([#937](#937)) ### Minor Changes - - Implement URL-based routing in overlay with BrowserRouter for web apps and HashRouter for Electron ([#921](#921)) - Remove sentry-integration.ts and simplify telemetry implementation - Moved telemetry logic from App.tsx to dedicated Telemetry component ### Patch Changes - Remove local resource handling and vite plugin as overlay feature is not supported ([#924](#924)) - Refactor to remove object destructuring from hooks returning only one value ([#930](#930)) ## @spotlightjs/sidecar@2.0.0 ### Major Changes - Make `setupSidecar` async as it should be ([#936](#936)) - Remove all vite-plugins as they are deprecated ([#937](#937)) ### Minor Changes - Add support for multiple stdio MCP servers to run, as a proxy for the existing main sidecar ([#935](#935)) - Adds stdio based MCP server via a `--stdio-mcp` CLI argument. Also removes the context-based message buffers to be able to achieve this as there's no context-id for the stdio transport. This feature was not used anyway. ([#933](#933)) Moves all log messages to stderr as they should have been to avoid clobbering the MCP stdio transport. ### Patch Changes - - To check all items in an envelope for errors. ([#880](#880)) - restructured the sidecar server and minor improvements ([#918](#918)) - To add a soft reset buffer when its cleared. ([#895](#895)) ## @spotlightjs/spotlight@4.0.0 ### Major Changes - Make `setupSidecar` async as it should be ([#936](#936)) - Remove all vite-plugins as they are deprecated ([#937](#937)) ### Minor Changes - Add support for multiple stdio MCP servers to run, as a proxy for the existing main sidecar ([#935](#935)) - Adds stdio based MCP server via a `--stdio-mcp` CLI argument. Also removes the context-based message buffers to be able to achieve this as there's no context-id for the stdio transport. This feature was not used anyway. ([#933](#933)) Moves all log messages to stderr as they should have been to avoid clobbering the MCP stdio transport. ### Patch Changes - Remove local resource handling and vite plugin as overlay feature is not supported ([#924](#924)) - Updated dependencies \[[`2fe54bb`](2fe54bb), [`20783d0`](20783d0), [`48c6753`](48c6753), [`65f4e9f`](65f4e9f), [`bb85759`](bb85759), [`1f2096e`](1f2096e), [`cec5457`](cec5457), [`5670dd4`](5670dd4), [`605b1e1`](605b1e1), [`69bfd17`](69bfd17), [`3d56a55`](3d56a55)]: - @spotlightjs/sidecar@2.0.0 - @spotlightjs/overlay@4.0.0 ## @spotlightjs/electron@1.8.0 ### Minor Changes - Run electron app in background and add a menu tray ([#929](#929)) - Make app window draggable ([#931](#931)) - Added Auto Updater ([#922](#922)) ### Patch Changes - - Implement URL-based routing in overlay with BrowserRouter for web apps and HashRouter for Electron ([#921](#921)) - Remove sentry-integration.ts and simplify telemetry implementation - Moved telemetry logic from App.tsx to dedicated Telemetry component - Updated dependencies \[[`2fe54bb`](2fe54bb), [`20783d0`](20783d0), [`48c6753`](48c6753), [`65f4e9f`](65f4e9f), [`bb85759`](bb85759), [`1f2096e`](1f2096e), [`cec5457`](cec5457), [`5670dd4`](5670dd4), [`605b1e1`](605b1e1), [`69bfd17`](69bfd17), [`3d56a55`](3d56a55)]: - @spotlightjs/sidecar@2.0.0 - @spotlightjs/overlay@4.0.0 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: to check all items in an envelope for errors

7519a1c

Shubhdeep12 requested review from BYK and MathurAditya724 August 6, 2025 18:11

vercel bot deployed to Preview August 6, 2025 18:14 View deployment

seer-by-sentry bot reviewed Aug 6, 2025

View reviewed changes

BYK approved these changes Aug 7, 2025

View reviewed changes

Merge branch 'main' into fix/get-errors-mcp

4b438b7

vercel bot deployed to Preview August 7, 2025 14:05 View deployment

fixed formatErrorEnvelope

d32cf0d

vercel bot temporarily deployed to Preview August 7, 2025 14:19 Inactive

MathurAditya724 reviewed Aug 7, 2025

View reviewed changes

Shubhdeep12 added 2 commits August 8, 2025 10:38

review comments addressed

3c20a8a

Merge branch 'main' into fix/get-errors-mcp

aa615e8

vercel bot temporarily deployed to Preview August 8, 2025 05:09 Inactive

Shubhdeep12 requested a review from MathurAditya724 August 8, 2025 05:09

MathurAditya724 approved these changes Aug 8, 2025

View reviewed changes

MathurAditya724 merged commit 65f4e9f into main Aug 8, 2025
18 checks passed

MathurAditya724 deleted the fix/get-errors-mcp branch August 8, 2025 15:54

sentry-release-bot bot mentioned this pull request Aug 25, 2025

meta(changelog): Update package versions #910

Merged

		const [{ type }, payload] = item;
		if (type === "event" && isErrorEvent(payload)) {

Uh oh!

fix: to check all items in an envelope for errors #880

fix: to check all items in an envelope for errors #880

Uh oh!

Conversation

Shubhdeep12 commented Aug 6, 2025

Uh oh!

codecov bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vercel bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seer-by-sentry bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

BYK left a comment

Choose a reason for hiding this comment

Uh oh!

BYK Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

BYK Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Shubhdeep12 Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

MathurAditya724 left a comment

Choose a reason for hiding this comment

Uh oh!

MathurAditya724 Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Shubhdeep12 Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

MathurAditya724 Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Shubhdeep12 Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

MathurAditya724 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Aug 6, 2025 •

edited

Loading

vercel bot commented Aug 6, 2025 •

edited

Loading