electron(fix): draggable electron window #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
BYK
approved these changes
Sep 17, 2025
Member
BYK
left a comment
BYK
left a comment
There was a problem hiding this comment.
Let's go without the window controls until we figure out how to make them not hideous
This reverts commit 8bc91a1.
betegon
pushed a commit
that referenced
this pull request
Sep 20, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/overlay@4.0.0 ### Major Changes - Remove integrations architecture in favour of fixed telemetry features and remove the ability to use the package as an overlay on top of apps. ([#917](#917)) - Remove all vite-plugins as they are deprecated ([#937](#937)) ### Minor Changes - - Implement URL-based routing in overlay with BrowserRouter for web apps and HashRouter for Electron ([#921](#921)) - Remove sentry-integration.ts and simplify telemetry implementation - Moved telemetry logic from App.tsx to dedicated Telemetry component ### Patch Changes - Remove local resource handling and vite plugin as overlay feature is not supported ([#924](#924)) - Refactor to remove object destructuring from hooks returning only one value ([#930](#930)) ## @spotlightjs/sidecar@2.0.0 ### Major Changes - Make `setupSidecar` async as it should be ([#936](#936)) - Remove all vite-plugins as they are deprecated ([#937](#937)) ### Minor Changes - Add support for multiple stdio MCP servers to run, as a proxy for the existing main sidecar ([#935](#935)) - Adds stdio based MCP server via a `--stdio-mcp` CLI argument. Also removes the context-based message buffers to be able to achieve this as there's no context-id for the stdio transport. This feature was not used anyway. ([#933](#933)) Moves all log messages to stderr as they should have been to avoid clobbering the MCP stdio transport. ### Patch Changes - - To check all items in an envelope for errors. ([#880](#880)) - restructured the sidecar server and minor improvements ([#918](#918)) - To add a soft reset buffer when its cleared. ([#895](#895)) ## @spotlightjs/spotlight@4.0.0 ### Major Changes - Make `setupSidecar` async as it should be ([#936](#936)) - Remove all vite-plugins as they are deprecated ([#937](#937)) ### Minor Changes - Add support for multiple stdio MCP servers to run, as a proxy for the existing main sidecar ([#935](#935)) - Adds stdio based MCP server via a `--stdio-mcp` CLI argument. Also removes the context-based message buffers to be able to achieve this as there's no context-id for the stdio transport. This feature was not used anyway. ([#933](#933)) Moves all log messages to stderr as they should have been to avoid clobbering the MCP stdio transport. ### Patch Changes - Remove local resource handling and vite plugin as overlay feature is not supported ([#924](#924)) - Updated dependencies \[[`2fe54bb`](2fe54bb), [`20783d0`](20783d0), [`48c6753`](48c6753), [`65f4e9f`](65f4e9f), [`bb85759`](bb85759), [`1f2096e`](1f2096e), [`cec5457`](cec5457), [`5670dd4`](5670dd4), [`605b1e1`](605b1e1), [`69bfd17`](69bfd17), [`3d56a55`](3d56a55)]: - @spotlightjs/sidecar@2.0.0 - @spotlightjs/overlay@4.0.0 ## @spotlightjs/electron@1.8.0 ### Minor Changes - Run electron app in background and add a menu tray ([#929](#929)) - Make app window draggable ([#931](#931)) - Added Auto Updater ([#922](#922)) ### Patch Changes - - Implement URL-based routing in overlay with BrowserRouter for web apps and HashRouter for Electron ([#921](#921)) - Remove sentry-integration.ts and simplify telemetry implementation - Moved telemetry logic from App.tsx to dedicated Telemetry component - Updated dependencies \[[`2fe54bb`](2fe54bb), [`20783d0`](20783d0), [`48c6753`](48c6753), [`65f4e9f`](65f4e9f), [`bb85759`](bb85759), [`1f2096e`](1f2096e), [`cec5457`](cec5457), [`5670dd4`](5670dd4), [`605b1e1`](605b1e1), [`69bfd17`](69bfd17), [`3d56a55`](3d56a55)]: - @spotlightjs/sidecar@2.0.0 - @spotlightjs/overlay@4.0.0 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last week, when removing the overlay feature (and some shadow dom stuff), I renamed the
idof the app root to"spotlight-root"inpackages/overlay/src/index.tsx:I didn't do a pass on the electron package, missing that the drag feature was based on getting this id.