fix(action): Use relative findings output path#289
Merged
Conversation
Write the findings artifact into the GitHub Actions workspace and expose the output as a repo-relative path. This keeps downstream upload actions from feeding absolute runner temp paths into ignore processors that expect relative paths. Also skip gitignore matching for outside-repo glob results so Warden does not trigger the same ignore package path validation error locally. Fixes #288 Co-Authored-By: GPT-5 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2b2200b. Configure here.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Move duplicate path normalization and repository-relative validation into the shared path utility. This keeps action findings output handling and CLI gitignore filtering on the same validation logic. Co-Authored-By: GPT-5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write Warden's findings JSON to the GitHub Actions workspace and expose the action output as a repo-relative path.
The previous output pointed at an absolute RUNNER_TEMP path. Downstream upload actions that apply ignore rules can reject those absolute paths because their ignore processors expect repo-relative pathnames.
This also guards Warden's own gitignore filtering so absolute glob matches outside the repo are not passed into ignore().ignores().
Fixes #288