fix(telemetry): Align attributes with OTel semantics#307
Merged
Conversation
Add a root telemetry investigation map for Warden production incidents. The map points to the shared Junior telemetry spec and gives Sentry query pivots for CLI runs, GitHub Action workflows, skill analysis, GenAI spans, finding processing, and fix evaluation. Co-Authored-By: GPT-5 <noreply@anthropic.com>
Add the direct Sentry Metrics recipe for finding total counts by skill and repository. This makes the skill metric dimension explicit for agents using the telemetry map. Co-Authored-By: GPT-5 <noreply@anthropic.com>
Use OTel semantic attributes for repository, source-code, CI/CD, and GenAI agent metadata. Namespace Warden-specific metrics and span attributes under warden.* so spans and metrics share one canonical query shape. Co-Authored-By: GPT-5 <noreply@anthropic.com>
dcramer
changed the title
Add the root telemetry investigation map to AGENTS.md so agents can discover the Sentry query guide while working in the repository. Co-Authored-By: GPT-5 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Only set warden.trigger.name when a skill task came from an actual trigger. Direct CLI skill runs now carry gen_ai.agent.name without synthetic trigger metadata. Remove telemetry-specific tests from the PR. Co-Authored-By: GPT-5 <noreply@anthropic.com>
The action now sets github.event.name once on the global Sentry scope. Remove the duplicate workflow span assignment so telemetry uses the shared scope. Co-Authored-By: GPT-5 Codex <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 997bad4. Configure here.
Use the GitHub Actions server URL for repository telemetry URLs so GHES runs do not point at github.com while run URLs point at the enterprise host. Add regression coverage for both GHES and default github.com URL construction. Co-Authored-By: GPT-5 Codex <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align Warden telemetry names around OpenTelemetry semantics and one canonical query shape.
Repository, source-code, CI/CD, and GenAI agent metadata now use the matching OTel semantic attributes where they exist. Warden-owned concepts such as triggers, hunks, findings, extraction, fix gate, deduplication, and fix evaluation are consistently namespaced under
warden.*across spans, logs, and metrics.The root telemetry map points at Junior’s shared telemetry spec and includes recipes for repository-scoped finding totals by skill using
gen_ai.agent.namewithvcs.owner.nameandvcs.repository.name. The metrics no longer emit compatibility aliases like rawskill,model,severity,findings.total, ortokens.input.Added focused tests for the Sentry telemetry helpers so repository scope, GitHub Actions scope, and skill metrics keep the OTel/Warden split intact.