fix(action): Validate Pi model selectors before execution#321
Merged
Conversation
dcramer
force-pushed
the
codex/invalid-pi-model-selector
branch
from
9e9a28e to
be9d251
Compare
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Share Pi model selector validation across CLI and GitHub Action paths so invalid WARDEN_MODEL values fail as configuration errors before runtime execution. Preserve invalid selector failures with a dedicated error code and Sentry tag so captured events show the real cause instead of collapsing into all-hunks-failed. Co-Authored-By: GPT-5 Codex <noreply@anthropic.com>
dcramer
force-pushed
the
codex/invalid-pi-model-selector
branch
from
be9d251 to
d220363
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Share Pi model selector validation between the CLI and GitHub Action paths.
The Action path could previously let an invalid Pi model selector, such as a bare WARDEN_MODEL value, reach runtime execution. That collapsed the failure into a generic all-hunks-failed path and made the captured Sentry event less useful. This moves selector validation into a shared helper and runs it before Action skill execution.
Action trigger failures now use a shared capture helper so PR and schedule workflows tag and fingerprint Sentry events consistently. Invalid selectors preserve a dedicated invalid_model_selector error code in runtime classification, JSONL output, and Action telemetry.
The schema and reporter spec were updated to document the new public error code. The fixture model names in Action tests now use provider/model selectors so they reflect the Pi runtime contract.