fix(action): Preload Pi node-only providers#324
Merged
Conversation
Preload Pi provider modules during GitHub Action startup so ncc-bundled runs do not hit Pi's non-literal node-only import paths during analysis. Register Bedrock's exported provider module and load the Codex provider under the same temporary rejection guard used for Pi's env-key probes. Fixes GH-322 Co-Authored-By: GPT-5 Codex <noreply@anthropic.com>
Member
Author
|
Im not happy with this long term, but the ncc fixes for now will be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preload Pi provider modules during GitHub Action startup so ncc-bundled action runs do not hit Pi non-literal node-only import paths during analysis.
Action Bundle Compatibility
The action now registers Pi Bedrock through the exported provider module and loads the Codex provider while the temporary ncc missing-builtin rejection guard is active. This mirrors Pi's own bundled entrypoint pattern and keeps lazy provider setup out of the later analysis path.
Validation
Local validation passed for lint, typecheck, the focused compatibility test, package build, action bundle build, and a preload smoke test. A full local pnpm test run still fails in src/cli/files.test.ts because fast-glob hits EACCES while scanning /tmp/snap-private-tmp, unrelated to this action change.
Fixes #322