ci(evals): only trigger on eval path changes#347
Merged
Conversation
PR #345 (a starlight-theme bump touching only package.json and pnpm-lock.yaml) ran the evals workflow because the lockfile and root package.json were listed as eval paths. Drop them from both the on.push.paths trigger and the should-run filter so evals only fire when packages/evals/ or the workflow itself changes, or when the run-evals label is applied. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-authored-by: David Cramer <dcramer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stop running the Evals workflow for PRs that only touch
package.jsonorpnpm-lock.yaml.Why
#345 (a
@sentry/starlight-themebump that only modified the docs lockfile entries) triggered the full evals suite. The lockfile and rootpackage.jsonwere listed as eval paths in two places:on.push.paths— any merge tomaintouching the lockfile would run evals on push.evalPathsarray inside theshould-runjob — any PR touching those files matched and ran evals.How
Removed
package.jsonandpnpm-lock.yamlfrom both lists. Evals now run only when:packages/evals/**changes,.github/workflows/evals.ymlchanges,run-evalslabel is applied to a PR, orThe
pull_requesttrigger stays broad (nopaths:filter) on purpose. GitHub applies path filters to every event type in a trigger block, so addingpathsthere would silently droplabeledevents on non-eval PRs and break therun-evalsescape hatch. Theshould-runjob is cheap (single script step, no checkout) so the broad trigger costs almost nothing.Slack Thread