fix(action): Report skipped PR trigger checks#353
Merged
Conversation
Create neutral per-skill check runs for configured PR triggers that do not match the current event. This lets required skill checks complete even when a trigger is skipped by action or path filters. Also complete the core check for missing config and no-match runs, and fail the core check when trigger execution reports errors. Fixes #351 Co-Authored-By: GPT-5 Codex <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure Warden reports a terminal check for every configured pull request trigger, even when the trigger is skipped by action or path filters. Skipped trigger checks complete as neutral so per-skill required checks like
warden: security-revieware present without running analysis.Core Check Completion
Missing configuration and no-match PR runs now complete the core
wardencheck as neutral instead of returning before reporting status. Trigger execution errors now cause the aggregate check to fail before the action exits.Skipped Trigger Checks
The PR workflow creates neutral per-skill checks for skipped PR-capable triggers while still running matched triggers normally. This keeps branch protection reliable without broadening what Warden analyzes.
Fixes #351