feat(apps): add Wave TV (from #44) - #45
Merged
Merged
Conversation
Android TV / Fire TV player for SUB/WAVE stations, submitted by @mrain1p in #44. The submission bot could not build a PR because the issue description exceeded 280 chars, so the entry is hand-authored: trimmed description and raw.githubusercontent.com image URLs (the issue gave github.com blob links, which serve HTML). Closes #44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
apps/wave-tv.jsonfor Wave TV — an Android TV / Fire TV player for SUB/WAVE stations, submitted by @mrain1p in #44.The submission bot couldn't build a PR: the issue description was over the 280-char cap when it last ran. Hand-authored instead, with two fixes:
raw.githubusercontent.com. The issue gavegithub.com/.../blob/...links — an allowed host, so they'd pass the build, but they serve an HTML page rather than the image. The icon was also pointed at thedevbranch; this usesmain. Both URLs verified 200 + correct content-type.Review notes:
type: mobileas submitted. There's notvbucket; this follows thesubwave-auto(Android Auto) precedent.catalog.jsonleft alone — it rebuilds on merge.Closes #44