Skip to content

BIP 110 Bitcoin Knots - #4237

Merged
al-lac merged 1 commit into
getumbrel:masterfrom
Retropex:RDTS
Jan 22, 2026
Merged

BIP 110 Bitcoin Knots#4237
al-lac merged 1 commit into
getumbrel:masterfrom
Retropex:RDTS

Conversation

@Retropex

@Retropex Retropex commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@Retropex
Retropex marked this pull request as draft December 12, 2025 06:49
@Roos7

Roos7 commented Dec 13, 2025

Copy link
Copy Markdown

Yes! I want to utilize the BIP110 and whatever else that will keep Bitcoin about money and only money. Satoshi's "'Bitcoin Constitution'" should remain as is and not be infiltrated by BS. I likened this scenario to what's happening in my Country (USA). We've been infiltrated, robbed, killed and seemingly indoctrinated to other things other than what the Original 'Constitution of the United States of America' means. This Bitcoin scene (Core v Knots) for me, runs deep within me. It's a matter of morality and Just. Keep what's right and clean nor wrong and dirty.

That's all I gawt to say 'bout thaaawt.

@sinnx3

sinnx3 commented Dec 16, 2025

Copy link
Copy Markdown

@nmfretz Any eta on getting this processed through?


@Retropex Leo, could we get this addition on your app store fork in the meantime? It's been about a week since initial PR.

@Retropex

Copy link
Copy Markdown
Contributor Author

This PR is voluntary suspended because too many people are rushing to run the code while it's still a release candidate and some bugs are still there.
I will reopen the PR once the RC2 is out.

@Roos7

Roos7 commented Jan 4, 2026 via email

Copy link
Copy Markdown

@Retropex

Retropex commented Jan 4, 2026

Copy link
Copy Markdown
Contributor Author

The most common port is 8332 on other platforms, but on Umbrel it’s indeed 9332.

@Roos7

Roos7 commented Jan 4, 2026 via email

Copy link
Copy Markdown

@Retropex

Retropex commented Jan 4, 2026

Copy link
Copy Markdown
Contributor Author

@nmfretz @al-lac This is ready to go!

Relevent commits:

Retropex/docker-bitcoind-prebuilt@798f808
Retropex/umbrel-bitcoin@edb8302

@Retropex
Retropex marked this pull request as ready for review January 4, 2026 23:13
@Retropex

Retropex commented Jan 5, 2026

Copy link
Copy Markdown
Contributor Author

Just pushed a quick regex update:
Retropex/umbrel-bitcoin@ec772d8

@Retropex

Copy link
Copy Markdown
Contributor Author

@nmfretz @al-lac any news on this?

@jesterhodl

Copy link
Copy Markdown

Looking forward to giving it a go

@maluquices

Copy link
Copy Markdown

Time to merge this please. Bitcoin is money.

@rdouma

rdouma commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

Also waiting for this. Time to tell spammers they can go play on Ethereum.

@cebas

cebas commented Jan 14, 2026

Copy link
Copy Markdown

Go 110, go!

@nmfretz

nmfretz commented Jan 15, 2026

Copy link
Copy Markdown
Member

Really sorry for the delay @Retropex! I've been completely distracted by other work. Testing now 🫡

@nmfretz

nmfretz commented Jan 15, 2026

Copy link
Copy Markdown
Member

@Retropex can you pls check that you're able to peer okay with the BIP 110 bitcoind? I'm having issues at the moment and wondering if it's just me.

@nmfretz

nmfretz commented Jan 15, 2026

Copy link
Copy Markdown
Member

the switching implementation and curl for DATUM etc is all perfect 👌

@Retropex

Copy link
Copy Markdown
Contributor Author

The current behavior is that BIP110 only outbound peer with other BIP110 nodes (it will be changed in RC3 to allow up to two non BIP110 outbound peer)

Have you -dnsseed enabled? My seed has been specifically modified to be able to seed BIP110 nodes.

You can test that your resolver can correctly fetch my seed with:

dig x8000009.seed.bitcoin.haf.ovh

@sinnx3

sinnx3 commented Jan 17, 2026

Copy link
Copy Markdown

Got tired of waiting on official store to merge, just replaced the docker-compose.yml and umbrel-app.yml from PR source and we're up and running fine with no issues, peering just fine with other bip110 nodes and my other nodes.

Disclaimer: I do not recommend doing this unless you know what you are doing and accept all risks of doing so.

image

@cebas

cebas commented Jan 19, 2026

Copy link
Copy Markdown

RC3 is out. Please merge. I want to signal ASAP 💪🏼

@Retropex
Retropex marked this pull request as draft January 19, 2026 07:58
@Retropex

Copy link
Copy Markdown
Contributor Author

Drafting again by the time I add RC3

@github-actions

Copy link
Copy Markdown

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ bitcoin-knots/docker-compose.yml Mounted file/directory "/bitcoin-knots/torrc" doesn't exist:
The volume "${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro" tries to mount the file/directory "/bitcoin-knots/torrc", but it is not present. This can lead to permission errors!
ℹ️ bitcoin-knots/docker-compose.yml External port mapping "${APP_BITCOIN_KNOTS_P2P_PORT}:${APP_BITCOIN_KNOTS_P2P_PORT}":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ bitcoin-knots/docker-compose.yml External port mapping "${APP_BITCOIN_KNOTS_RPC_PORT}:${APP_BITCOIN_KNOTS_RPC_PORT}":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ bitcoin-knots/docker-compose.yml Using unsafe user "root" in service "i2pd_daemon":
The user "root" can lead to security vulnerabilities. If possible please use a non-root user instead.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@Retropex
Retropex marked this pull request as ready for review January 19, 2026 11:28
@Retropex

Copy link
Copy Markdown
Contributor Author

Pushed RC3.

Relevent commits:

Retropex/umbrel-bitcoin@709f134
Retropex/docker-bitcoind-prebuilt@357b59f

@nmfretz RC3 add non BIP110 peering up to two peers, you should no longer have peering issues if your addrman doesn't have any BIP110 address.

@Conza88

Conza88 commented Jan 20, 2026

Copy link
Copy Markdown

Yes. Please. 🔥

@sharknoon

Copy link
Copy Markdown
Contributor

I have tested the Bitcoin Knots app on my Raspberry Pi with BIP 110 selected and it seems to work fine 🚀

@Retropex

Copy link
Copy Markdown
Contributor Author

Hey @nmfretz @lukechilds @al-lac, I’m getting a lot of requests for this update, would it be possible to merge soon?

@ranathan14

ranathan14 commented Jan 22, 2026

Copy link
Copy Markdown

I can’t wait for the change to be available. Go Bitcoin! go @nmfretz @lukechilds @al-lac🚀

@al-lac

al-lac commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

Hey @Retropex, thanks a lot for providing this update and your patience.

We wanted to test it properly before providing it to all users.

As @sharknoon, @nmfretz and myself have now tested it successfully, we can finally go live! 🎉

@al-lac
al-lac merged commit e8fa896 into getumbrel:master Jan 22, 2026
1 check passed
@Retropex

Copy link
Copy Markdown
Contributor Author

Amazing, thanks!

@Retropex
Retropex deleted the RDTS branch January 22, 2026 13:00
@cebas

cebas commented Jan 22, 2026

Copy link
Copy Markdown

Signaling NOW!
Thanks!

@rdouma

rdouma commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

Me too. I think it would be nice if the update message in the Umbrel App Store would indicate explicitly that simply upgrading in itself won't signal BIP110 and that the user needs to change a setting for it to start doing so.

@cebas

cebas commented Jan 22, 2026

Copy link
Copy Markdown

Me too. I think it would be nice if the update message in the Umbrel App Store would indicate explicitly that simply upgrading in itself won't signal BIP110 and that the user needs to change a setting for it to start doing so.

I agree. I have the "Always use the latest version" selected, but the BIP110 wasn't selected in spite of being newer. I think the sort isn't working well with this special version. So I had to select it manually.

@Retropex

Copy link
Copy Markdown
Contributor Author

I have the "Always use the latest version" selected, but the BIP110 wasn't selected in spite of being newer.

That's expected, not all users want BIP110. A softfork should be opt-in and not opt-out.

@cebas

cebas commented Jan 22, 2026

Copy link
Copy Markdown

I have the "Always use the latest version" selected, but the BIP110 wasn't selected in spite of being newer.

That's expected, not all users want BIP110. A softfork should be opt-in and not opt-out.

You're right.
A special message would be useful, anyway.

@rdouma

rdouma commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

I have the "Always use the latest version" selected, but the BIP110 wasn't selected in spite of being newer.

That's expected, not all users want BIP110. A softfork should be opt-in and not opt-out.

I agree, a soft fork should be opt-in. However, since most upgrades automatically activate new functionality, there is now going to be a group of people that won't realize they need to do more than just upgrade. I think there now will be many users that will skim over that simple message and think that by installing this release they have activated BIP110. I know I wasn't sure when I upgraded.

Honestly, I believe it would be even better if there was a pop-up question when you open Bitcoin Knots, but I don't see anything negative about explaining it a bit more in the upgrade dialog on the App Store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.