Skip to content

Update Knots to v29.3.knots20260210 and BIP 110 to v29.3.knots20260210-bip110-v0.3 - #4720

Merged
nmfretz merged 2 commits into
getumbrel:masterfrom
Retropex:v29.3
Feb 19, 2026
Merged

Update Knots to v29.3.knots20260210 and BIP 110 to v29.3.knots20260210-bip110-v0.3#4720
nmfretz merged 2 commits into
getumbrel:masterfrom
Retropex:v29.3

Conversation

@Retropex

@Retropex Retropex commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

@Retropex
Retropex force-pushed the v29.3 branch 2 times, most recently from ac7ca62 to 552cbf1 Compare February 13, 2026 15:48
@Retropex Retropex changed the title Update Knots to v29.3.knots20260210 Update Knots to v29.3.knots20260210 and BIP 110 to ghcr.io/retropex/bitcoin:29.3.knots20260210-bip110-v0.2 Feb 13, 2026
@Retropex Retropex changed the title Update Knots to v29.3.knots20260210 and BIP 110 to ghcr.io/retropex/bitcoin:29.3.knots20260210-bip110-v0.2 Update Knots to v29.3.knots20260210 and BIP 110 to v29.3.knots20260210-bip110-v0.2 Feb 13, 2026
@Retropex

Copy link
Copy Markdown
Contributor Author

Hey @al-lac, would it be possible to merge this soon?
There are important fixes inside.
Thanks!

@al-lac

al-lac commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Hey @Retropex, I wanted @nmfretz to have a look first to be sure.

Do you also now want to align the version with the UI version instead of the bitcoin version?

@Retropex

Copy link
Copy Markdown
Contributor Author

Yes I should have done that from the start.
It even make more sense today with BIP110 being included.

@dathonohm

Copy link
Copy Markdown

This should be updated to v0.3 before merging, if possible: https://github.com/dathonohm/bitcoin/releases/tag/v29.3.knots20260210%2Bbip110-v0.3

@Retropex

Copy link
Copy Markdown
Contributor Author

Updated to v0.3

@Retropex Retropex changed the title Update Knots to v29.3.knots20260210 and BIP 110 to v29.3.knots20260210-bip110-v0.2 Update Knots to v29.3.knots20260210 and BIP 110 to v29.3.knots20260210-bip110-v0.3 Feb 16, 2026
@Retropex

Copy link
Copy Markdown
Contributor Author

@al-lac @nmfretz any news? This really needs to be merged.

@nmfretz

nmfretz commented Feb 18, 2026

Copy link
Copy Markdown
Member

Sorry @Retropex 🙏. Will get on this today!

@nmfretz

nmfretz commented Feb 18, 2026

Copy link
Copy Markdown
Member

Looks good and working well @Retropex. Before we go live, do you think it's worth mentioning in the release notes that users who currently have selected BIP110 in Settings don't need to do anything after updating the app, since they'll be automatically upgraded to v29.3.knots20260210-bip110-v0.3?

I'm thinking it could be good for two reasons:

  1. Users who are currently on BIP110 might be confused on whether or not they need to do something since all 110 users needed to manually select BIP110 in Settings at some point.

  2. The way the version feature says it works in the UI is that if a user selects a specific version in Settings then they ... stay on a specific version until you change it manually.. So it might be good to explicitly mention it in the release notes. It totally makes sense to do in this case, I just want to make sure you don't get attacked here 😅

    image

@nmfretz

nmfretz commented Feb 18, 2026

Copy link
Copy Markdown
Member

Ah, taking a look at the Datum PR now as well @Retropex since you could slip in your change before we merge

Edit: responded here

@github-actions

Copy link
Copy Markdown

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ bitcoin-knots/docker-compose.yml Mounted file/directory "/bitcoin-knots/torrc" doesn't exist:
The volume "${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro" tries to mount the file/directory "/bitcoin-knots/torrc", but it is not present. This can lead to permission errors!
ℹ️ bitcoin-knots/docker-compose.yml External port mapping "${APP_BITCOIN_KNOTS_P2P_PORT}:${APP_BITCOIN_KNOTS_P2P_PORT}":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ bitcoin-knots/docker-compose.yml External port mapping "${APP_BITCOIN_KNOTS_RPC_PORT}:${APP_BITCOIN_KNOTS_RPC_PORT}":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ bitcoin-knots/docker-compose.yml Using unsafe user "root" in service "i2pd_daemon":
The user "root" can lead to security vulnerabilities. If possible please use a non-root user instead.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@Retropex

Copy link
Copy Markdown
Contributor Author

That make sense, I have added it to the release note.

@Retropex

Copy link
Copy Markdown
Contributor Author

@nmfretz the datum discutions is resolved, we can merge this PR.

@nmfretz

nmfretz commented Feb 19, 2026

Copy link
Copy Markdown
Member

Awesome, thanks for your patience @Retropex! Going live.

@nmfretz
nmfretz merged commit 117abfd into getumbrel:master Feb 19, 2026
1 check passed
@Retropex
Retropex deleted the v29.3 branch March 10, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants