advance: adopt declared target on first multiple_new_tests, no extra suite runs - #91
Merged
Conversation
TDD-Run: 14 TDD-Cycle: 1 TDD-Phase: red
TDD-Run: 14 TDD-Cycle: 1 TDD-Phase: green
…dict TDD-Run: 14 TDD-Cycle: 1 TDD-Phase: refactor
TDD-Run: 14 TDD-Cycle: 2 TDD-Phase: red
…pened TDD-Run: 14 TDD-Cycle: 2 TDD-Phase: green
…e same advance TDD-Run: 14 TDD-Cycle: 2 TDD-Phase: refactor
… same advance TDD-Run: 14 TDD-Cycle: 3 TDD-Phase: refactor
TDD-Run: 14 TDD-Cycle: 4 TDD-Phase: red
TDD-Run: 14 TDD-Cycle: 4 TDD-Phase: green
…he declared id TDD-Run: 14 TDD-Cycle: 4 TDD-Phase: refactor
TDD-Run: 14 TDD-Cycle: 5 TDD-Phase: red
…e rule) TDD-Run: 14 TDD-Cycle: 5 TDD-Phase: green
TDD-Run: 14 TDD-Cycle: 6 TDD-Phase: pin
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_outcome_from_verdictshelper: looks up the already-executed test verdict from theVerdictobjects returned byrun_projects, returningFAILED/PASSED/None.tdd advanceagain, the adopted target is judged from the run that already happened — committing RED or demanding sensitivity in the sameadvancecall._disambiguate: resolves an ambiguousmultiple_new_testssituation by normalisation match (issue advance: normalise describe/test id separator so a formatting-only difference is not a declared_test_mismatch #57) or unique same-file candidate, without asking the agent; genuinely ambiguous cases still route throughtdd target._disambiguateinto thelen(candidates) > 1branch so same-file disambiguation also evaluates in one advance.docs/PRD.mdto document same-advance evaluation and the two disambiguation rules.Quality gates
uv run ruff check src tests— all checks passeduv run pytest— 424 passed (418 baseline + 6 new)Test coverage note
All decision-point operators in new code are covered by at least one test (pseudo-mutation analysis passed).
Closes #72