Skip to content

advance: adopt declared target on first multiple_new_tests, no extra suite runs - #91

Merged
geuben merged 16 commits into
mainfrom
feat/72-adopt-on-first-run
Aug 29, 2026
Merged

advance: adopt declared target on first multiple_new_tests, no extra suite runs#91
geuben merged 16 commits into
mainfrom
feat/72-adopt-on-first-run

Conversation

@geuben

@geuben geuben commented Aug 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds _outcome_from_verdicts helper: looks up the already-executed test verdict from the Verdict objects returned by run_projects, returning FAILED/PASSED/None.
  • Wires evaluation into the single-candidate adoption branch: instead of asking the agent to run tdd advance again, the adopted target is judged from the run that already happened — committing RED or demanding sensitivity in the same advance call.
  • Adds _disambiguate: resolves an ambiguous multiple_new_tests situation by normalisation match (issue advance: normalise describe/test id separator so a formatting-only difference is not a declared_test_mismatch #57) or unique same-file candidate, without asking the agent; genuinely ambiguous cases still route through tdd target.
  • Wires _disambiguate into the len(candidates) > 1 branch so same-file disambiguation also evaluates in one advance.
  • Updates R8.9 in docs/PRD.md to document same-advance evaluation and the two disambiguation rules.

Quality gates

  • uv run ruff check src tests — all checks passed
  • uv run pytest — 424 passed (418 baseline + 6 new)

Test coverage note

All decision-point operators in new code are covered by at least one test (pseudo-mutation analysis passed).

Closes #72

geuben added 15 commits August 29, 2026 08:06
TDD-Run: 14
TDD-Cycle: 1
TDD-Phase: green
…dict

TDD-Run: 14
TDD-Cycle: 1
TDD-Phase: refactor
…pened

TDD-Run: 14
TDD-Cycle: 2
TDD-Phase: green
…e same advance

TDD-Run: 14
TDD-Cycle: 2
TDD-Phase: refactor
… same advance

TDD-Run: 14
TDD-Cycle: 3
TDD-Phase: refactor
TDD-Run: 14
TDD-Cycle: 4
TDD-Phase: red
TDD-Run: 14
TDD-Cycle: 4
TDD-Phase: green
…he declared id

TDD-Run: 14
TDD-Cycle: 4
TDD-Phase: refactor
…e rule)

TDD-Run: 14
TDD-Cycle: 5
TDD-Phase: green
@geuben
geuben merged commit 871a048 into main Aug 29, 2026
10 checks passed
@geuben geuben mentioned this pull request Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

advance: adopt the declared target on the first multiple_new_tests instead of burning extra suite runs

1 participant