Add missing validation for timestamp writes in render and compute passes

[ErichDonGubler]

Connections

-

Description

It turns out, no validation for timestamp writes' indices or even query type was present. Holy crap! Fix that plz. Apply all validation that the WebGPU spec. specifies in:

• GPUCommandEncoder.beginRenderPass, step 10 on the device timeline
• GPUCommandEncoder.beginComputePass, step 4 on the device timeline

Testing

• CTS coverage:
  • Most of webgpu:api,validation,encoding,beginComputePass:timestampWrites,*
    • Render pass equivalent missing from CTS, but I've filed an issue upstream: Add coverage for GPURenderPassDescriptor.timestampWrites a la compute passes gpuweb/cts#4056
    • webgpu:api,validation,encoding,beginComputePass:timestampWrites,invalid_query_set:querySetState="invalid" is specifically resolved by fix(core): validate dst_buffer isn't destroyed when resolving query sets #6579.
    • Deferred webgpu:api,validation,encoding,beginComputePass:timestampWrites,query_index: beginningOfPassWriteIndex="_undef_";endOfPassWriteIndex="_undef_" to Validate that at least one index must be specified in pass timestamp writes #6583.
  • webgpu:api,validation,encoding,beginRenderPass:occlusion_query_set,device_mismatch:*
  • webgpu:api,validation,encoding,beginRenderPass:timestamp_query_set,device_mismatch:*
• Some PRs follow this one, and writing coverage is nontrivial. Punting in-tree testing to Test pass timestamp writes validation #6584.

Checklist

• Run cargo fmt.
• Run taplo format.
• Run cargo clippy. If applicable, add:
  • --target wasm32-unknown-unknown
  • --target wasm32-unknown-emscripten
• Run cargo xtask test to run tests.
• Add change to CHANGELOG.md. See simple instructions inside file.

[Wumpf]

unit test would be nice :)

[ErichDonGubler]

@Wumpf:

unit test would be nice :)

Filed #6584 to follow up with it, and updated the OP.