Use automod for folders where tests are collected
#7389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Curious what @gfx-rs/wgpu thinks of this one. I don't see it as controversial, but I recognize that it can be. 🙂 |
ErichDonGubler
force-pushed
the
automod-tests
branch
from
9bbf30e to
4c790ea
Compare
ErichDonGubler
force-pushed
the
automod-tests
branch
from
4c790ea to
eb8bee9
Compare
ErichDonGubler
added
area: infrastructure
Member
|
Promoted this to the next wgpu maintainers meeting. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommended review is commit-by-commit, with rebase-and-merging.
WGPU is the sort of projects that lives and dies off of its tests. Making tests easy to author is an important choice for us to make, and, if possible, we'd like to make it as easy as "add a file here and write your code".
Often, we need to add new
modentries for Rust-based tests. This can cause conflicts, and has no real value to us. This same dynamic motivates crates likeautomod, which automatically enumerate child modules in Rust source based on the presence of files.Partially automate away the papercut of adding
modentries by usingautomod::dir!()in directories that have multiple tests underneath them.