Add enable extensions for ray queries and ray query vertex returns. #8545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Nov 18, 2025
Member
cwfitzgerald
left a comment
cwfitzgerald
left a comment
There was a problem hiding this comment.
Could you add some tests for this in wgsl_errors.rs
Vecvec
force-pushed
the
ray-query-enable
branch
from
81a809a to
7245701
Compare
cwfitzgerald
approved these changes
Nov 18, 2025
|
|
||
| #### General | ||
|
|
||
| - Require new enable extensions when using ray queries and position fetch (`wgpu_ray_query`, `wgpu_ray_query_vertex_return`). By @Vecvec in [#8545](https://github.com/gfx-rs/wgpu/pull/8545). |
Member
There was a problem hiding this comment.
thought: Would a BREAKING callout be helpful?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
As discussed on matrix
Description
Adds an enable extension for ray tracing (
wgpu_ray_query), because ray queries came in before wgpu supported enable extensions.Testing
adds enable to the ray tracing tests
Squash or Rebase?
squash
Checklist
cargo fmt.cargo clippy --tests.cargo xtask testto run tests.CHANGELOG.mdentry.