Repository navigation
Replies: 2 comments
|
A small update in general for all discussions, a Tailscale device has been provided to am17an for testing with RDNA3.5 and 4. I myself can provide another machine through Tailscale with RDNA3.5 and 4 but the 4 is over TB5 in an external razor enclosure and would include a .pem and ssh access with root. |
0 replies
|
For this set of PRs some important information - rocWMMA has been removed #26046 |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
AMD PR Set 3 of 6 — Review and Summarization Flash Attention Optimization RDNA3.5
Johannes and llama.cpp team, below is a group of related patches from AMD intended to optimize a set of high-priority models on the ROCm backend. I've grouped these together — from a larger set of patches — to hopefully make your job easier in reviewing them, and I've provided a short summary for each. These PR numbers (
#40,#41, etc.) refer to the AMD team's downstream fork atAMD-Ecosystem/llama.cpp, where this work landed first; the goal is to bring it upstream in reviewable batches.This third group is the smallest: two patches covering flash-attention with head dim D=256 on RDNA3.5, one for each build variant (rocWMMA on and off). Both are RDNA3.5 gated and change kernel selection/tile config.
3. Flash-Attention RDNA3.5 D=256 Optimizations
ncols2query heads into a full 16-wide tile instead of leaving the wmma-f16 tile mostly empty. +13.7% pp1024.nbatch_K128 -> 64, occupancy 3 -> 4). Small effect on this model; helps models with a 256-wide head dim more directly.I have spoke to @am17an please feel free to start pushing PRs into llama.cpp and reference this discussion, also as you tag this discussion I'll update the PR links to the llama.cpp PRs as they come in for accuracy.
Discussions:
AMD PR Set 1 of 6 — Tooling and Profiling modifications and additions
AMD PR Set 2 of 6 — MMQ and MoE - MatMul Optimizations
AMD PR Set 3 of 6 — Flash Attention Optimization RDNA3.5
AMD PR Set 4 of 6 Matvec and Fusion Decode Optimizations
AMD PR Set 5 of 6 — GEMM Prefill Weight Optimizations
AMD PR Set 6 of 6 - Layout and Concurrency Optimizations
All reactions