cli: Remove redundant local sampling variables (#20429)#22264
Merged
pwilkin merged 1 commit intoggml-org:masterfrom Apr 23, 2026
Merged
cli: Remove redundant local sampling variables (#20429)#22264pwilkin merged 1 commit intoggml-org:masterfrom
pwilkin merged 1 commit intoggml-org:masterfrom
Conversation
This change implements the third requested change in issue 20429. Because defaults.sampling contains the reasoning budget token count and the reasoning budget message, it's not necessary to assign them to struct variables.
Contributor
Author
|
@pwilkin @ggerganov would either of you be able to take a look? I realized I missed this in #22233 |
ggerganov
approved these changes
Apr 23, 2026
pwilkin
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This change implements the third requested change in issue 20429. Because defaults.sampling contains the reasoning budget token count and the reasoning budget message, it's not necessary to assign them to struct variables.
Additional information
#20429
Requirements