mtmd: add chunk save/load function - #26645
Merged
Merged
Conversation
ggerganov
approved these changes
Aug 6, 2026
| MTMD_INPUT_CHUNK_TYPE_TEXT, | ||
| MTMD_INPUT_CHUNK_TYPE_IMAGE, | ||
| MTMD_INPUT_CHUNK_TYPE_AUDIO, | ||
| MTMD_INPUT_CHUNK_TYPE_MAX, // for validation |
Member
There was a problem hiding this comment.
Using MTMD_INPUT_CHUNK_TYPE_COUNT would be more consistent with the rest of the codebase.
Contributor
|
@ngxson This is a much cleaner and more general foundation than adding cache-only fields to Once this API is merged, I will update #26640 to use The slot-specific integration will remain in #26640: the chunk positions, the outer file framing, the consistency checks against the restored token sequence, and the server-side tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add a save/load API call for mtmd_input_chunk, ref: #26640 (review)
Requirements