bitnet: honor relu2 hidden_activation from GGUF (fixes microsoft/BitNet#602) - #26751
Open
msrovani wants to merge 1 commit into
Open
bitnet: honor relu2 hidden_activation from GGUF (fixes microsoft/BitNet#602)#26751msrovani wants to merge 1 commit into
msrovani wants to merge 1 commit into
Conversation
|
Hi @msrovani, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
Member
|
Is this the same as #25885 (comment)? |
CISC
reviewed
Aug 8, 2026
CISC
left a comment
CISC
left a comment
Member
There was a problem hiding this comment.
Please update OP with our PR template.
Comment on lines
+10
to
+11
| if (ml.get_key(LLM_KV_HIDDEN_ACT, hidden_act, false)) { | ||
| hparams.llm_ffn_op = llm_ffn_op_type_from_string(hidden_act, LLM_FFN_SILU); |
Member
There was a problem hiding this comment.
This is slightly problematic as it translates silu to LLM_FFN_SWIGLU.
See 1bitLLM/bitnet_b1_58-3B/config.json.
When I flagged this earlier I don't think we came to any solution on how to distinguish this, so I think you will just have to check and change it back to LLM_FFN_SILU.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/BitNet#602. The official bitnet-b1.58-2B-4T declares hidden_act: relu2 but the bitnet arch hardcodes LLM_FFN_SILU in build_ffn, producing wrong-but-finite logits on every backend.
Changes:
LLM_FFN_RELU_SQR with LLM_FFN_PAR gating produces exactly relu2(gate) * up, matching the HF BitnetMLP (act_fn(gate) * up).