Skip to content

server: report the isolate working directory from get_info - #26773

Merged
ngxson merged 2 commits into
ggml-org:masterfrom
ServeurpersoCom:server/get-info-isolate-cwd
Aug 8, 2026
Merged

server: report the isolate working directory from get_info#26773
ngxson merged 2 commits into
ggml-org:masterfrom
ServeurpersoCom:server/get-info-isolate-cwd

Conversation

@ServeurpersoCom

@ServeurpersoCom ServeurpersoCom commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Overview

get_info reports the working directory the tools actually run in.

When a tools runtime is configured, the tools run inside the isolate, which starts in a directory of its own. get_info was still reporting the server process working directory, so it named a host path nothing would ever run in. It now asks the isolate instead.

Nothing changes when the tools run on the host, or when a working directory is set from the WebUI: that value is still reported as is.

Additional information

Without fix, this return the llama-server CWD :

Sans titre

built-in tools on a minimalist/basic telegram bot

telegram

UI CWD work as before :

2

Requirements

Without an explicit cwd, get_info fell back to the server process
working directory even when a tools runtime was configured. That named a
host path no tool would ever run in, since an isolate starts in a
directory of its own.

It now asks the isolate for its working directory in that case, and
keeps the process one only when the tools run on the host.
@ServeurpersoCom
ServeurpersoCom requested a review from a team as a code owner August 8, 2026 17:49
@github-actions github-actions Bot added the server label Aug 8, 2026
@ServeurpersoCom
ServeurpersoCom requested a review from ngxson August 8, 2026 18:21
Comment thread tools/server/server-tools.cpp Outdated
@ngxson
ngxson merged commit 7ba604f into ggml-org:master Aug 8, 2026
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants