sycl : add Kronecker product FWHT support for sizes 384, 640, 768, 1280 - #28016
Conversation
There was a problem hiding this comment.
This pr extends the FWHT to support a wider range of common embeddings. If you guys find this useful, I'll extends this to more generalized dimensions. Thanks @ggerganov
arthw
left a comment
There was a problem hiding this comment.
It's good job!
The UT cases are passed on B60 and iGPU in Ultra 7 265K.
Thank you!
|
@philip-jingxin Thank you! Very reasonable changes. |
|
I too hastilly merged this PR, I believe as it breaks github actions. @philip-jingxin can you create a follow-up PR fixing the build issues? |
@Titaniumtown My bad! I've created a follow-up PR fixing the Thanks! |
Overview
Extends FWHT with Kronecker product to support non-power-of-two common embedding dimensions 384, 640, 768, 1280
Additional information
Changes
kronecker_kernelto handle base blocks oftests/test-backend-ops.cppto cover non-power-of-two sizes for Hadamard transformation.Testing & Verification
Environment
./build_hadamard/bin/test-backend-ops test -o MUL_MAT_HADAMARD -b SYCL0Correctness Test
Passed 16/16 verification tests, including non-power-of-two sizes (m= 384, 640, 768, 1280) across various configurations:
Performance Benchmarks
Measured on Intel UHD Graphics 770:
Requirements