Skip to content

[codex] Ignore defaulted env references in review checks#29

Merged
joerucci merged 1 commit into
mainfrom
clarify-cashier-env-suppression
Jul 3, 2026
Merged

[codex] Ignore defaulted env references in review checks#29
joerucci merged 1 commit into
mainfrom
clarify-cashier-env-suppression

Conversation

@joerucci

@joerucci joerucci commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Updates review reference handling so env references with explicit fallback/default arguments are tracked as defaulted instead of required. Defaulted references no longer create blocking missing encrypted value findings, missing schema warnings, or missing .env.example warnings on their own.

Root Cause

The review scanner treated every env(...)-style reference as a required Ghostable-managed value. That made default-backed framework config values, such as Laravel Cashier settings, block review even when the framework provides safe defaults and the value does not need to exist in ENV.

Changes

  • Adds default-aware metadata to changed env references.
  • Applies missing encrypted value, schema, and .env.example checks only to required references.
  • Supports explicit default arguments for PHP/Laravel env, Python os.getenv / os.environ.get / environ.get, and Ruby ENV.fetch.
  • Tightens PHP getenv() matching so it does not also match Python os.getenv().
  • Adds regression tests covering defaulted Cashier-style config keys and still-required plain env references.

Validation

  • go test ./internal/review
  • go test ./...

@joerucci
joerucci marked this pull request as ready for review July 3, 2026 20:54
@joerucci
joerucci merged commit 466d90b into main Jul 3, 2026
9 checks passed
@joerucci
joerucci deleted the clarify-cashier-env-suppression branch July 3, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant