Update README's instructions#283
Conversation
|
Looks good to me, the only part I think, there is one final step missing, which will be to run 'npm run postinstall' command to rename some wrong import in react native. |
|
@pavel-cliqz I think the |
README.md
Outdated
| This branch is for mainline development. | ||
|
|
||
| This branch only works with Xcode 9.3 and supports iOS 10, and 11. | ||
| This branch only works with Xcode 10.1 and supports iOS 10, and 11. |
There was a problem hiding this comment.
supports ios 10, 11 and 12
There was a problem hiding this comment.
small comment that I found, not a big deal, but maybe make sense to change. other then that looks great
There was a problem hiding this comment.
Good point. As per Naira's comment I changed it into "11 and above".
naira-cliqz
left a comment
naira-cliqz
left a comment
There was a problem hiding this comment.
Other than mentioned comments it looks fine for me as well. Thank you @pavel-cliqz and @remusao !
README.md
Outdated
| This branch is for mainline development. | ||
|
|
||
| This branch only works with Xcode 9.3 and supports iOS 10, and 11. | ||
| This branch only works with Xcode 10.1 and supports iOS 10, and 11. |
There was a problem hiding this comment.
It actually support ios 11 and above. Could you please fix this line
There was a problem hiding this comment.
@naira-cliqz 11 or 10.3? The deployment target i see is 10.3
There was a problem hiding this comment.
There is another deploment target for the target itself which is 11, and it overwrites project target. Project target comes from FF and we didn't change it to avoid one more merge conflict
| ```shell | ||
| sh ./bootstrap.sh | ||
| npm ci | ||
| npm run bundle-lumen |
There was a problem hiding this comment.
here we can add 2 cause for Lumen bundle-lumen and for Ghostery bundle-ghostery
There was a problem hiding this comment.
Added a second command. Thanks for the suggestion.
|
@naira-cliqz @pavel-cliqz Thanks for the review. I updated the PR accordingly. |
4 participants
This PR updates
README.mdwith updated instructions to build the project from scratch. @pavel-cliqz thanks for your help with this, could you maybe have a look and check everything I changed makes sense?Notes for testing this patch
Ideally the instructions should be enough to start from a fresh install of MacOS Mojave and build the project successfully.