This repository was archived by the owner on Jun 23, 2020. It is now read-only.
Simplified TrackerStateStore and CC Bug fixes#89
Merged
mahmoud-adam85 merged 5 commits intoghostery:masterfrom Jul 12, 2018
Merged
Simplified TrackerStateStore and CC Bug fixes#89mahmoud-adam85 merged 5 commits intoghostery:masterfrom
mahmoud-adam85 merged 5 commits intoghostery:masterfrom
Conversation
added 2 commits
July 11, 2018 17:51
mahmoud-adam85
suggested changes
Jul 12, 2018
| if !self.trustSiteButton.isSelected { | ||
| self.delegate?.changeAll(state: .trusted, tableType: .page, completion: { | ||
|
|
||
| self.delegate?.pauseGhostery(paused: false, time: Date()) |
Contributor
There was a problem hiding this comment.
Can you move these lines into a new method and call it instead of duplicating the code multiple times?
mahmoud-adam85
approved these changes
Jul 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.