I think I've found the fix for a longstanding issue #13402
-
What do you want to change?I'd like to fix the issue described in #5389 where the macOS tab bar goes black after disconnecting an external monitor when in fullscreen. I believe the root cause is bailing from didChangeScreenParametersNotification when in fullscreen mode as this prevents syncAppearance from being called. I reproduced the bug with a debug build using BetterDisplay and then I tested adding in an extra call to syncAppearance before returning from didChangeScreenParametersNotification and it worked. It might not be the most correct fix for the project, and if it's not I'm hoping I can see this bug through, learn more about working on Ghostty, and contribute (even a little) to a tool I use day in and day out. Why do you want to make this change?This bug happens frequently to me as I am often connecting and disconnecting monitors and the proposed solution (programatically cycle through the tabs) seems like the wrong way to me (and it hasn't been accepted as the fix yet either). I acknowledge that:
|
Beta Was this translation helpful? Give feedback.
Replies: 1 comment
-
|
!vouch |
Beta Was this translation helpful? Give feedback.
!vouch