PR triage: fix for #3288 (discussion) enabling reset zoom button with macos-titlebar-style = tabs and one tab

[danielwe]

I implemented a fix for #3288 such that the reset zoom button also works for macos-titlebar-style = tabs when only one (no?) tab is present. See the branch/diff at main...danielwe:ghostty:fix-zoom-tabs

Do you want a PR?

This fix was simply to remove an unnecessary branch, as the titlebar style doesn't make any difference for the required logic. If the tab bar is visible, you should unconditionally hide the titlebar's button and rely on the per-tab buttons. If the tab bar is not visible, you should hide or show the titlebar button depending on surfaceIsZoomed.

A small wrinkle was that the toolbar title started showing on top of/blended with the tabs, presumably because of some change in the calculations that previously sent it to overflow. (I suppose the calculus changes because we're no longer removing resetZoomTitlebarAccessoryViewController.) In any case, it seems brittle to rely on it being pushed to overflow, so I added a few lines of code to properly hide it when the tab bar is visible. As a bonus, this means that hideToolbarOverflowButton can be removed entirely. (EDIT: removing hideToolbarOverflowButton was too optimistic, see comment below, so I reverted that part.)

Screenshots:

[danielwe]

Update: I noticed that I'd occasionally get the overflow button even with the toolbar title properly hidden, so I reverted the removal of hideToolbarOverflowButton. It’s still needed.

[mitchellh]

Yes, excellent. Thank you. I'll do a proper review on the PR, but appreciate it.