gtk: terminal bell - #2231
Closed
jcollie wants to merge 4 commits into
Closed
Conversation
Member
Author
|
Added @pluiedev 's patches for x11/wayland attention. |
Member
Author
|
rebased onto current |
Pangoraw
reviewed
Sep 16, 2024
Member
Author
|
Rebased onto current main to fix conflict caused by Toast PR. |
mitchellh
added a commit
that referenced
this pull request
Sep 16, 2024
The syntax of tagged unions is `tag:value`. This matches the tagged union parsing syntax for keybindings (i.e. `new_split:right`). I'm adding this now on its own without a user-facing feature because I can see some places we might use this and I want to separate this out. There is already a PR open now that can utilize this (#2231).
mitchellh
added a commit
that referenced
this pull request
Sep 16, 2024
The syntax of tagged unions is `tag:value`. This matches the tagged union parsing syntax for keybindings (i.e. `new_split:right`). I'm adding this now on its own without a user-facing feature because I can see some places we might use this and I want to separate this out. There is already a PR open now that can utilize this (#2231).
mitchellh
added a commit
that referenced
this pull request
Sep 16, 2024
The syntax of tagged unions is `tag:value`. This matches the tagged union parsing syntax for keybindings (i.e. `new_split:right`). I'm adding this now on its own without a user-facing feature because I can see some places we might use this and I want to separate this out. There is already a PR open now that can utilize this (#2231).
mitchellh
added a commit
that referenced
this pull request
Sep 16, 2024
The syntax of tagged unions is `tag:value`. This matches the tagged union parsing syntax for keybindings (i.e. `new_split:right`). I'm adding this now on its own without a user-facing feature because I can see some places we might use this and I want to separate this out. There is already a PR open now that can utilize this (#2231).
mitchellh
added a commit
that referenced
this pull request
Sep 16, 2024
The syntax of tagged unions is `tag:value`. This matches the tagged union parsing syntax for keybindings (i.e. `new_split:right`). I'm adding this now on its own without a user-facing feature because I can see some places we might use this and I want to separate this out. There is already a PR open now that can utilize this (#2231).
Member
Author
|
Rebased on to current main and adjusted the code to take advantage of the generic tagged union parsing. |
mitchellh
requested changes
Sep 17, 2024
mitchellh
left a comment
mitchellh
left a comment
Contributor
There was a problem hiding this comment.
I think my biggest issue is the complexity Wayland introduces.
A few requests:
- Can we remove Wayland from this PR?
- In the future, can we use the Wayland C API rather than Zig? That'll make it easier for us to upgrade Zig versions?
Member
Author
|
I've backed out the Wayland patches. |
|
This is a great feature! Thanks! |
Member
Author
|
rebased onto current main |
Member
Author
|
rebased to latest main |
Use GTK's media streaming APIs to implement the terminal bell. By default it's disabled since it's likely that only a small subset of people will want this feature. Currently only audio support is implemented but there's scaffolding for several other methods of alerting the user. NOTE: GTK needs to have access to GStreamer and the "base" and "good" plugins or it crashes when you try to play a sound. I've added the necessary packages to the NixOS developer shell and package but I haven't found a method yet to detect the situation and avoid the crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use GTK's media streaming APIs to implement the terminal bell. By default it's disabled since it's likely that only a small subset of people will want this feature. Currently only audio support is implemented but there's scaffolding for several other methods of alerting the user.
NOTE: GTK needs to have access to GStreamer and the "base" and "good" plugins or it crashes when you try to play a sound. I've added the necessary packages to the NixOS developer shell and package but I haven't found a method yet to detect the situation and avoid the crash.