Fix flatpak packaging to a working state

[alaviss]

This should make testing Flatpak builds a lot easier.

To build, enter flatpak/ directory and run:

flatpak-builder --repo=repo builddir com.mitchellh.ghostty.yml

alternatively, using org.flatpak.Builder flatpak:

flatpak run -p org.flatpak.Builder \
  --repo=repo \
  builddir \
  com.mitchellh.ghostty.yml

The resulting flatpak can be installed using

flatpak install ./repo com.mitchellh.ghostty

Credit of AppStream metadata goes to @yorickpeterse.

[alaviss]

Rebased to Zig 0.14.0.

Due to #6734 and #6733, flatpak-builder will not be able to build Ghostty at the moment.

[alaviss]

Rebased to main, flatpak build is now fully functional.

[tulilirockz]

This isnt enforced by the flathub review process. At least I havent ran into this at all when publishing flatpak manifests to Flathub

[alaviss]

It sounds like a requirement if you're publishing straight from here to Flathub, though. At least I see that Firefox and OBS are following it.

[mitchellh]

I'm trying to verify this so we can get it merged but I'm getting build errors locally:

Cache miss, checking out last cache hit
========================================================================
Building module ghostty in /home/mitchellh/code/go/src/github.com/ghostty-org/ghostty/flatpak/.flatpak-builder/build/ghostty-2
========================================================================
Updated Git hooks.
Git LFS initialized.
Note: switching to '4182b7fa42f27cf14a71dbdb54cfd82c5c6e3447'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 4182b7f switch zigimg ref to merged commit
Updated Git hooks.
Git LFS initialized.
Note: switching to '4a002763419a34d61dcbb1f415821b83b9bf8ddc'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 4a00276 Merge pull request 'fix removed b.host on v0.14.0-dev.2568+42dac40b3' (#25) from e0328eric/zg:master into master
Updated Git hooks.
Git LFS initialized.
fatal: unable to read tree (0ce4eca3560d5553b13263d6b6bb72e146dd43d0)
Error: module ghostty: Child process exited with code 128

Any ideas?

[alaviss]

fatal: unable to read tree (0ce4eca3560d5553b13263d6b6bb72e146dd43d0)

Looks like it's zigimg again.

They force pushed their master branch so now the commit referenced is unreachable from default branch.

Maybe I'll have to fix the cache gen script to prefer downloading archives instead...

[alaviss]

Rebased and fixed the issue with zigimg. The flatpak should build correctly now.

[alaviss]

Rebased to main and updated package cache.

[alaviss]

Rebased to main and dropped zigimg workaround, given that the fork's author committed to stop force pushing.

[yorickpeterse]

Is there anything that's holding back this PR (or reviewing of it)? 😃

[00-kat]

To quote Mitchell from Discord:

Its on me, I was ready to merge it before and just couldn't make it work locally. I have to run this locally to make sure it all works (so I can debug it one day if it doesn't) and then we hsould be good to go.

[mitchellh]

Okay hurray the build works for me. I want to add some CI checks next and we should be good. CI may be annoying though lets see!

[tulilirockz]

Flathub recently moved to github workflows for CI, maybe there would be something useful there?

[mitchellh]

Okay, a couple important CI failures and I'm not quite sure what they are yet:

• For some reason check-zig-cache.sh works on my local system (with Nix) but not in CI.
• Seeing a strange failure about lazy dependencies here: https://github.com/ghostty-org/ghostty/actions/runs/14601245977/job/40959653302

If anyone has ideas, that's blocking this, because we need CI to make sure this doesn't bitrot.

[alaviss]

For some reason check-zig-cache.sh works on my local system (with Nix) but not in CI.

It's correct to fail, the lock file in main changed between the last rebase and now (and GHA runs on the merged head of main and this PR).
You'd have to merge main into this and update the deps.

[mitchellh]

Good catch, trying again.

[alaviss]

It might be useful to also build the .Devel variant for debugging purposes, but I don't know if Flatpak GHA uploads debuginfo.

[mitchellh]

Thanks, CI looks good! I'm going to polish up the runs and dependencies a bit and we should b good

[mitchellh]

Thanks for sticking with this PR. With the Flatpak build being verified in CI now this should help keep everything much more stable. 😄