Skip to content

Adapt component views to support type information#54

Merged
gusevda merged 6 commits intomainfrom
entity-page-improvements
Aug 8, 2023
Merged

Adapt component views to support type information#54
gusevda merged 6 commits intomainfrom
entity-page-improvements

Conversation

@gusevda
Copy link
Copy Markdown
Contributor

@gusevda gusevda commented Aug 8, 2023

What does this PR do?

In this PR:

  • Type column added to catalog page;
  • Tags column is hidden to provide more space for other columns;
  • Entity page was changed:
    • Limited view is used for "customer" and "template" components.
    • Limited view with Dependencies tab is used for "appcatalog" components.
    • Full view is used for other components.

How does it look like?

Limited view:
Screenshot 2023-08-08 at 14 17 21

Full view:
Screenshot 2023-08-08 at 13 50 09

Any background context you can provide?

https://github.com/giantswarm/giantswarm/issues/27739

Should this change be mentioned in the release notes?

  • CHANGELOG.md has been updated

@gusevda gusevda marked this pull request as ready for review August 8, 2023 10:54
@gusevda gusevda requested a review from a team as a code owner August 8, 2023 10:54
@gusevda gusevda requested a review from marians August 8, 2023 10:55
@marians
Copy link
Copy Markdown
Member

marians commented Aug 8, 2023

  • I like the list page with type and without tags!
  • I think for type configuration we should also show tabs PRs, actions, CircleCI.
  • for type customer and template, I would remove the dependencies tab

@gusevda gusevda merged commit 126f458 into main Aug 8, 2023
@gusevda gusevda deleted the entity-page-improvements branch August 8, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants