Values: Fix schema.#580
Merged
Merged
Conversation
|
There were differences in the rendered Helm template, please check! Output |
njuettner
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses an issue, which popped up after upgrading Helm to v3.18.5+ in MC Bootstrap.
https://tekton.ci.giantswarm.io/#/namespaces/mc-bootstrap/pipelineruns/pr-1354-generate-mc-capz-goose-nxr4f?pipelineTask=generate-mc&step=generate-mc
Since
cluster-azureis not usingnodePoolKind: MachinePool, the conditions in the schema do not evaluate to define theinfrastructureMachinePoolproperty and so this is not known when trying to install the chart in MC Bootstrap.But since we are using the
infrastructureMachinePoolproperty in both cases -nodePoolKind: MachinePoolandnodePoolKind: MachineDeploymenteverywhere in the code, I movedinfrastructureMachinePoolto the previous conditions so it gets defined.