ci: bump giantswarm/architect orb to 8.2.1#263
Merged
Conversation
v8.2.1 picks up architect-orb#767 which makes
image-login-to-registries POSIX-portable. This unblocks
architect/sync-china-registry (the gsoci -> Aliyun mirror via the
in-China galaxy-runner). Since 8.1.0 (i.e. since the split-china-push
migration), every sync-china-registry invocation in this repo's tag
pipelines has been failing on Login to registries with /bin/sh:
syntax error: bad substitution.
The bash regression was introduced in architect-orb#736; #767 reverted
the bash-isms (${!var}, [[ ... ]], ==) back to POSIX-portable
equivalents (eval-based indirection, [ ... ], =).
v8.2.x also enables cosign keyless signing, SLSA provenance, and SBOM
attestations by default for public images and charts.
architect@8.2.0 turned chart cosign signing on by default (`sign: true`) on `push-to-app-catalog`. The signing step shells out to `cosign` from the executor that runs the job. This repo overrides `executor: app-build-suite` so that the `app_build_suite` Python CLI is available to package the chart, and the `app-build-suite` image (gsoci.azurecr.io/giantswarm/app-build-suite) does not ship cosign. Without this opt-out, every chart push fails on the `Mint Sigstore OIDC token` step with `/bin/bash: cosign: command not found`. Pin `sign: false` on every `push-to-app-catalog*` invocation to restore pre-8.2.0 behaviour while the orb is patched to either install cosign on-demand or ship it in the `app-build-suite` executor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
giantswarm/architectorb8.1.0->8.2.1.Why
v8.2.1 ships architect-orb#767, which makes the shared
image-login-to-registriescommand POSIX-portable. The v8.1.0 refactor (#736) had accidentally introduced bash-only${!var}indirect expansion and[[ ... ]]test brackets, which BusyBox/bin/sh(used by theregctlexecutor underarchitect/sync-china-registry) rejects with/bin/sh: syntax error: bad substitution.Since this repo migrated to
split-china-push: true+sync-china-registry, every tag pipeline's mirror step has been failing before any login was attempted -- so no image has actually been mirrored gsoci -> Aliyun since 2026-05-18. This bump unblocks the next tag pipeline's mirror step.v8.2.x also enables, by default, cosign keyless signing, SLSA provenance, and SBOM attestations for public images and Helm charts (closes the supply-chain loop for public artifacts in this repo).
Test plan
v*tag exercisessync-china-registryend-to-end (the gsoci side already works under 8.1.0; the Aliyun mirror is the new behaviour being validated).