Feat: Return condition result so it can be used as a result of the workflow#21
Merged
Feat: Return condition result so it can be used as a result of the workflow#21
Conversation
…test scenarios - Changed Store field in WorkflowStep from string to bool type - Updated workflow executor to use step ID as storage key when Store: true - Fixed template variable regex to support hyphens in step IDs - Updated test framework to handle boolean Store field correctly - Fixed 50+ failing test scenarios with template variables and expectations - Achieved 100% test success rate (149/149 scenarios passing) - Regenerated schema.json to reflect boolean Store field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and refactors across multiple files to improve workflow configuration, testing, and execution handling. The key changes include standardizing the
storeattribute, adding new features for conditional workflows, and improving template handling. Below is a breakdown of the most important changes grouped by theme.Workflow Configuration Enhancements:
storeattribute from a string to a boolean across multiple YAML configurations to simplify result storage logic. This affects files likeworkflow-arg-templating.yaml,workflow-advanced.yaml, and various testing scenarios. [1] [2] [3] [4] [5] [6] [7] [8] [9]Conditional Workflow Features:
FromStepin conditions, along with new attributes likeExpectNotfor negated condition expectations. This enables more robust conditional logic in workflows.service-health-workflow) with steps for checking service status, restarting unhealthy services, creating missing services, and reporting final status. [1] [2]Template Engine Improvement:
-) in variable names, increasing flexibility in template definitions.Testing Scenario Adjustments:
storeattribute format and updated references to execution IDs for improved clarity and consistency. This affects scenarios likeworkflow-execution-basic-tracking.yamlandworkflow-execution-cleanup.yaml. [1] [2] [3] [4] [5]Workflow Step Enhancements:
AllowFailureattribute to workflow steps, enabling steps to fail without halting the entire workflow, while still making their results available for subsequent conditions.